Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add percentage to size column #2990

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR changes up the size column for the assets table adding in the percentage of each asset and what percentage they take up of the total bundle size.

Closes codecov/engineering-team#1804

Notable Changes

  • Create new function to format bundle percentages
  • Update size column sorting so that it sorts off of the percentages
  • Create/Update tests

Screenshots

Screenshot 2024-07-08 at 09 45 05

@codecov-qa
Copy link

codecov-qa bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (9125b95) to head (d192447).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2990   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files         902      902           
  Lines       13318    13343   +25     
  Branches     3487     3560   +73     
=======================================
+ Hits        13096    13121   +25     
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx 100.00% <100.00%> (ø)
src/shared/utils/bundleAnalysis.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.47% <ø> (ø)
Pages 99.15% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.69% <100.00%> (+<0.01%) ⬆️
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9125b95...d192447. Read the comment docs.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (9125b95) to head (d192447).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #2990   +/-   ##
===========================================
  Coverage   98.33000   98.33000           
===========================================
  Files           902        902           
  Lines         13318      13343   +25     
  Branches       3487       3560   +73     
===========================================
+ Hits          13096      13121   +25     
  Misses          218        218           
  Partials          4          4           
Files Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx 100.00% <100.00%> (ø)
src/shared/utils/bundleAnalysis.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.47% <ø> (ø)
Pages 99.15% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.69% <100.00%> (+<0.01%) ⬆️
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9125b95...d192447. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2990   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files         902      902           
  Lines       13318    13343   +25     
  Branches     3553     3560    +7     
=======================================
+ Hits        13096    13121   +25     
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx 100.00% <100.00%> (ø)
src/shared/utils/bundleAnalysis.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.47% <ø> (ø)
Pages 99.15% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.69% <100.00%> (+<0.01%) ⬆️
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9125b95...d192447. Read the comment docs.

Copy link

codecov-public-qa bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (9125b95) to head (d192447).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2990   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files         902      902           
  Lines       13318    13343   +25     
  Branches     3558     3493   -65     
=======================================
+ Hits        13096    13121   +25     
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx 100.00% <100.00%> (ø)
src/shared/utils/bundleAnalysis.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.47% <ø> (ø)
Pages 99.15% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.69% <100.00%> (+<0.01%) ⬆️
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9125b95...d192447. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jul 8, 2024

Bundle Report

Changes will increase total bundle size by 1.26kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.08MB 1.26kB ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jul 8, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
5dcc3bf Mon, 08 Jul 2024 13:05:44 GMT Expired Expired
d192447 Tue, 09 Jul 2024 16:56:23 GMT Cloud Enterprise

Copy link

codecov bot commented Jul 8, 2024

Bundle Report

Changes will increase total bundle size by 1.26kB ⬆️

Bundle name Size Change
gazebo-production-array-push 6.08MB 1.26kB ⬆️

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, had my questions answered on slack :)

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit a766666 Jul 11, 2024
61 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-1804-add-percentage-to-size-column branch July 11, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Add in size column to show asset percentage
3 participants