-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add percentage to size column #2990
feat: Add percentage to size column #2990
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2990 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 902 902
Lines 13318 13343 +25
Branches 3487 3560 +73
=======================================
+ Hits 13096 13121 +25
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2990 +/- ##
===========================================
Coverage 98.33000 98.33000
===========================================
Files 902 902
Lines 13318 13343 +25
Branches 3487 3560 +73
===========================================
+ Hits 13096 13121 +25
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2990 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 902 902
Lines 13318 13343 +25
Branches 3553 3560 +7
=======================================
+ Hits 13096 13121 +25
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2990 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 902 902
Lines 13318 13343 +25
Branches 3558 3493 -65
=======================================
+ Hits 13096 13121 +25
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 1.26kB ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Bundle ReportChanges will increase total bundle size by 1.26kB ⬆️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, had my questions answered on slack :)
Description
This PR changes up the size column for the assets table adding in the percentage of each asset and what percentage they take up of the total bundle size.
Closes codecov/engineering-team#1804
Notable Changes
size
column sorting so that it sorts off of the percentagesScreenshots