Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove session expiry tracker #2988

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix: Remove session expiry tracker #2988

merged 2 commits into from
Jul 8, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented Jul 5, 2024 •
edited
Loading

Removes the SessionExpiryTracker code that requires users to log back in every eight hours. Corresponding PR API side to come, but this can be merged without issue.

We will be replacing this behaviour with something else in a future PR.

Also adds code to clean up old Cookie and localStorage items. To be removed later.

Part of codecov/engineering-team#2025

@codecov-qa
Copy link

codecov-qa bot commented Jul 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (2664937) to head (131b02b).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2988   +/-   ##
=======================================
  Coverage   98.32%   98.33%           
=======================================
  Files         903      902    -1     
  Lines       13375    13318   -57     
  Branches     3565     3487   -78     
=======================================
- Hits        13151    13096   -55     
+ Misses        220      218    -2     
  Partials        4        4
Files Coverage Δ
src/config.js 100.00% <100.00%> (ø)
src/layouts/BaseLayout/BaseLayout.jsx 96.42% <ø> (ø)
...ts/EnterpriseLoginLayout/EnterpriseLoginLayout.tsx 100.00% <100.00%> (ø)
...ts/Header/components/UserDropdown/UserDropdown.tsx 100.00% <ø> (ø)
src/layouts/LoginLayout/LoginLayout.tsx 100.00% <100.00%> (ø)
src/layouts/OldHeader/Dropdown.tsx 100.00% <ø> (ø)
src/shared/utils/metrics.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.47% <100.00%> (-0.06%) ⬇️
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.18% <ø> (-0.06%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2664937...131b02b. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jul 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2988   +/-   ##
=======================================
  Coverage   98.32%   98.33%           
=======================================
  Files         903      902    -1     
  Lines       13375    13318   -57     
  Branches     3499     3487   -12     
=======================================
- Hits        13151    13096   -55     
+ Misses        220      218    -2     
  Partials        4        4
Files Coverage Δ
src/config.js 100.00% <100.00%> (ø)
src/layouts/BaseLayout/BaseLayout.jsx 96.42% <ø> (ø)
...ts/EnterpriseLoginLayout/EnterpriseLoginLayout.tsx 100.00% <100.00%> (ø)
...ts/Header/components/UserDropdown/UserDropdown.tsx 100.00% <ø> (ø)
src/layouts/LoginLayout/LoginLayout.tsx 100.00% <100.00%> (ø)
src/layouts/OldHeader/Dropdown.tsx 100.00% <ø> (ø)
src/shared/utils/metrics.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.47% <100.00%> (-0.06%) ⬇️
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.18% <ø> (-0.06%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2664937...131b02b. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Jul 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (2664937) to head (131b02b).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2988   +/-   ##
=======================================
  Coverage   98.32%   98.33%           
=======================================
  Files         903      902    -1     
  Lines       13375    13318   -57     
  Branches     3499     3487   -12     
=======================================
- Hits        13151    13096   -55     
+ Misses        220      218    -2     
  Partials        4        4
Files Coverage Δ
src/config.js 100.00% <100.00%> (ø)
src/layouts/BaseLayout/BaseLayout.jsx 96.42% <ø> (ø)
...ts/EnterpriseLoginLayout/EnterpriseLoginLayout.tsx 100.00% <100.00%> (ø)
...ts/Header/components/UserDropdown/UserDropdown.tsx 100.00% <ø> (ø)
src/layouts/LoginLayout/LoginLayout.tsx 100.00% <100.00%> (ø)
src/layouts/OldHeader/Dropdown.tsx 100.00% <ø> (ø)
src/shared/utils/metrics.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.47% <100.00%> (-0.06%) ⬇️
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.18% <ø> (-0.06%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2664937...131b02b. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jul 5, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 1.16kB ⬇️

Bundle name Size Change
gazebo-staging-array-push 6.78MB 1.16kB ⬇️

@codecov Codecov
Copy link

codecov bot commented Jul 5, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 1.16kB ⬇️

Bundle name Size Change
gazebo-production-array-push 6.78MB 1.16kB ⬇️

@codecov Codecov
Copy link

codecov bot commented Jul 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (2664937) to head (131b02b).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #2988        +/-   ##
================================================
+ Coverage   98.32000   98.33000   +0.01000     
================================================
  Files           903        902         -1     
  Lines         13375      13318        -57     
  Branches       3545       3558        +13     
================================================
- Hits          13151      13096        -55     
+ Misses          220        218         -2     
  Partials          4          4
Files Coverage Δ
src/config.js 100.00% <100.00%> (ø)
src/layouts/BaseLayout/BaseLayout.jsx 96.42% <ø> (ø)
...ts/EnterpriseLoginLayout/EnterpriseLoginLayout.tsx 100.00% <100.00%> (ø)
...ts/Header/components/UserDropdown/UserDropdown.tsx 100.00% <ø> (ø)
src/layouts/LoginLayout/LoginLayout.tsx 100.00% <100.00%> (ø)
src/layouts/OldHeader/Dropdown.tsx 100.00% <ø> (ø)
src/shared/utils/metrics.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.47% <100.00%> (-0.06%) ⬇️
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.18% <ø> (-0.06%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2664937...131b02b. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jul 5, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
fb09b1a Fri, 05 Jul 2024 19:39:41 GMT Expired Expired
131b02b Mon, 08 Jul 2024 16:25:11 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review July 5, 2024 19:40
nicholas-codecov
nicholas-codecov approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me, just one question, what is the expiry value for COOKIE_SESSION_EXPIRY? Wondering if we should leave in a clean up for a bit of time to remove the cookie from the users browser.

@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/remove-session-expiry-tracker branch from fb09b1a to 131b02b Compare July 8, 2024 16:14
nicholas-codecov
nicholas-codecov approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Jul 8, 2024
Merged via the queue into main with commit bfe41cb Jul 8, 2024
61 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/remove-session-expiry-tracker branch July 8, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholas-codecov nicholas-codecov nicholas-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spalmurray-codecov @codecov-releaser @nicholas-codecov