Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add in bundle chart #2984

Merged
merged 6 commits into from
Jul 4, 2024
Merged

feat: Add in bundle chart #2984

merged 6 commits into from
Jul 4, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR puts all of the pieces together and adds in the bundle chart component to the bundles tab.

Blocked by #2983

Closes codecov/engineering-team#1802

Notable Changes

  • Add in TrendDropdown component for bundle selecting
  • Add in BundleChart component
  • Add BundleChart to BundleContent
  • Adjust BundleSummary styles
  • Create/Update tests

Screenshots

Screenshot 2024-07-04 at 07 33 46

@codecov-qa
Copy link

codecov-qa bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (855b1a4) to head (35885df).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2984   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         890      892    +2     
  Lines       13257    13267   +10     
  Branches     3468     3534   +66     
=======================================
+ Hits        13040    13050   +10     
  Misses        213      213           
  Partials        4        4
Files Coverage Δ
...ndlesTab/BundleContent/BundleChart/BundleChart.tsx 100.00% <100.00%> (ø)
...lesTab/BundleContent/BundleChart/TrendDropdown.tsx 100.00% <100.00%> (ø)
...epoPage/BundlesTab/BundleContent/BundleContent.tsx 100.00% <ø> (ø)
...sTab/BundleContent/BundleSummary/BundleSummary.tsx 100.00% <ø> (ø)
src/shared/utils/bundleAnalysis.ts 100.00% <ø> (ø)
src/ui/BundleTrendChart/BundleTrendChart.tsx 90.00% <100.00%> (+2.50%) ⬆️
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.23% <ø> (ø)
Pages 99.16% <100.00%> (+<0.01%) ⬆️
Services 99.46% <ø> (ø)
Shared 99.68% <ø> (-0.01%) ⬇️
UI 94.59% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855b1a4...35885df. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2984   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         890      892    +2     
  Lines       13257    13267   +10     
  Branches     3538     3469   -69     
=======================================
+ Hits        13040    13050   +10     
  Misses        213      213           
  Partials        4        4
Files Coverage Δ
...ndlesTab/BundleContent/BundleChart/BundleChart.tsx 100.00% <100.00%> (ø)
...lesTab/BundleContent/BundleChart/TrendDropdown.tsx 100.00% <100.00%> (ø)
...epoPage/BundlesTab/BundleContent/BundleContent.tsx 100.00% <ø> (ø)
...sTab/BundleContent/BundleSummary/BundleSummary.tsx 100.00% <ø> (ø)
src/shared/utils/bundleAnalysis.ts 100.00% <ø> (ø)
src/ui/BundleTrendChart/BundleTrendChart.tsx 90.00% <100.00%> (+2.50%) ⬆️
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.23% <ø> (ø)
Pages 99.16% <100.00%> (+<0.01%) ⬆️
Services 99.46% <ø> (ø)
Shared 99.68% <ø> (-0.01%) ⬇️
UI 94.59% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855b1a4...35885df. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (855b1a4) to head (35885df).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2984   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         890      892    +2     
  Lines       13257    13267   +10     
  Branches     3514     3469   -45     
=======================================
+ Hits        13040    13050   +10     
  Misses        213      213           
  Partials        4        4
Files Coverage Δ
...ndlesTab/BundleContent/BundleChart/BundleChart.tsx 100.00% <100.00%> (ø)
...lesTab/BundleContent/BundleChart/TrendDropdown.tsx 100.00% <100.00%> (ø)
...epoPage/BundlesTab/BundleContent/BundleContent.tsx 100.00% <ø> (ø)
...sTab/BundleContent/BundleSummary/BundleSummary.tsx 100.00% <ø> (ø)
src/shared/utils/bundleAnalysis.ts 100.00% <ø> (ø)
src/ui/BundleTrendChart/BundleTrendChart.tsx 90.00% <100.00%> (+2.50%) ⬆️
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.23% <ø> (ø)
Pages 99.16% <100.00%> (+<0.01%) ⬆️
Services 99.46% <ø> (ø)
Shared 99.68% <ø> (-0.01%) ⬇️
UI 94.59% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855b1a4...35885df. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jul 4, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 16.45kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.75MB 16.45kB ⬆️

@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 16.45kB ⬆️

Bundle name Size Change
gazebo-production-array-push 6.75MB 16.45kB ⬆️

@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (855b1a4) to head (35885df).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #2984   +/-   ##
===========================================
  Coverage   98.36000   98.36000           
===========================================
  Files           890        892    +2     
  Lines         13257      13267   +10     
  Branches       3533       3515   -18     
===========================================
+ Hits          13040      13050   +10     
  Misses          213        213           
  Partials          4          4
Files Coverage Δ
...ndlesTab/BundleContent/BundleChart/BundleChart.tsx 100.00% <100.00%> (ø)
...lesTab/BundleContent/BundleChart/TrendDropdown.tsx 100.00% <100.00%> (ø)
...epoPage/BundlesTab/BundleContent/BundleContent.tsx 100.00% <ø> (ø)
...sTab/BundleContent/BundleSummary/BundleSummary.tsx 100.00% <ø> (ø)
src/shared/utils/bundleAnalysis.ts 100.00% <ø> (ø)
src/ui/BundleTrendChart/BundleTrendChart.tsx 90.00% <100.00%> (+2.50%) ⬆️
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.23% <ø> (ø)
Pages 99.16% <100.00%> (+<0.01%) ⬆️
Services 99.46% <ø> (ø)
Shared 99.68% <ø> (-0.01%) ⬇️
UI 94.59% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855b1a4...35885df. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jul 4, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
6f18d95 Thu, 04 Jul 2024 10:47:51 GMT Expired Expired
06eafce Thu, 04 Jul 2024 13:06:08 GMT Expired Expired
35885df Thu, 04 Jul 2024 13:45:31 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov force-pushed the gh-eng-1802-add-in-bundle-chart branch from 6f18d95 to 06eafce Compare July 4, 2024 12:49
spalmurray-codecov
spalmurray-codecov approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 319a841 Jul 4, 2024
61 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-1802-add-in-bundle-chart branch July 4, 2024 15:08
spalmurray-codecov pushed a commit that referenced this pull request Jul 4, 2024
@nicholas-codecov @spalmurray-codecov
feat: Add in bundle chart (#2984)
50ed086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmurray-codecov spalmurray-codecov spalmurray-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Add in bundle trend chart to bundles tab
3 participants
@nicholas-codecov @codecov-releaser @spalmurray-codecov