-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gazebo] Add subtotals row on coverage page + test fix #2977
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2977 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 889 888 -1
Lines 13152 13168 +16
Branches 3479 3438 -41
=======================================
+ Hits 12935 12951 +16
Misses 213 213
Partials 4 4
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2977 +/- ##
===========================================
Coverage 98.35000 98.35000
===========================================
Files 889 888 -1
Lines 13152 13168 +16
Branches 3433 3507 +74
===========================================
+ Hits 12935 12951 +16
Misses 213 213
Partials 4 4
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2977 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 889 888 -1
Lines 13152 13168 +16
Branches 3497 3507 +10
=======================================
+ Hits 12935 12951 +16
Misses 213 213
Partials 4 4
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2977 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 889 888 -1
Lines 13152 13168 +16
Branches 3479 3438 -41
=======================================
+ Hits 12935 12951 +16
Misses 213 213
Partials 4 4
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
@ai-review-prompt-prod |
I've reviewed this Pull Request and have no helpful feedback. |
Bundle ReportChanges will increase total bundle size by 521 bytes ⬆️
|
Bundle ReportChanges will increase total bundle size by 521 bytes ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Even whipped out the calculator to double check the sums in preview deploy 😂
Description
See design.
codecov/engineering-team#1453 is the original issue.
Since we auto update the coverage totals already, this issue has been updated to sum up the column totals in each row(excluding name and coverage %) IFF we have 2 or more rows.
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.