Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gazebo] Add subtotals row on coverage page + test fix #2977

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Jul 2, 2024

Description

See design.

codecov/engineering-team#1453 is the original issue.

Since we auto update the coverage totals already, this issue has been updated to sum up the column totals in each row(excluding name and coverage %) IFF we have 2 or more rows.

Screenshots

Screenshot 2024-07-02 at 11 51 18 AM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2977   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         889      888    -1     
  Lines       13152    13168   +16     
  Branches     3479     3438   -41     
=======================================
+ Hits        12935    12951   +16     
  Misses        213      213           
  Partials        4        4           
Files Coverage Δ
...route/FileExplorer/CodeTreeTable/CodeTreeTable.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.15% <100.00%> (+<0.01%) ⬆️
Services 99.46% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.58% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 675354d...c59ce79. Read the comment docs.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (675354d) to head (c59ce79).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #2977   +/-   ##
===========================================
  Coverage   98.35000   98.35000           
===========================================
  Files           889        888    -1     
  Lines         13152      13168   +16     
  Branches       3433       3507   +74     
===========================================
+ Hits          12935      12951   +16     
  Misses          213        213           
  Partials          4          4           
Files Coverage Δ
...route/FileExplorer/CodeTreeTable/CodeTreeTable.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.15% <100.00%> (+<0.01%) ⬆️
Services 99.46% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.58% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 675354d...c59ce79. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (675354d) to head (c59ce79).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2977   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         889      888    -1     
  Lines       13152    13168   +16     
  Branches     3497     3507   +10     
=======================================
+ Hits        12935    12951   +16     
  Misses        213      213           
  Partials        4        4           
Files Coverage Δ
...route/FileExplorer/CodeTreeTable/CodeTreeTable.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.15% <100.00%> (+<0.01%) ⬆️
Services 99.46% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.58% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 675354d...c59ce79. Read the comment docs.

Copy link

codecov-public-qa bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (675354d) to head (c59ce79).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2977   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         889      888    -1     
  Lines       13152    13168   +16     
  Branches     3479     3438   -41     
=======================================
+ Hits        12935    12951   +16     
  Misses        213      213           
  Partials        4        4           
Files Coverage Δ
...route/FileExplorer/CodeTreeTable/CodeTreeTable.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.15% <100.00%> (+<0.01%) ⬆️
Services 99.46% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.58% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 675354d...c59ce79. Read the comment docs.

@rohitvinnakota-codecov
Copy link
Contributor Author

@ai-review-prompt-prod

Copy link

codecov-ai bot commented Jul 2, 2024

I've reviewed this Pull Request and have no helpful feedback.

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 521 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.74MB 521 bytes ⬆️

Copy link

codecov bot commented Jul 2, 2024

Bundle Report

Changes will increase total bundle size by 521 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 6.74MB 521 bytes ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jul 2, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
2da432b Tue, 02 Jul 2024 16:00:04 GMT Expired Expired
c59ce79 Tue, 02 Jul 2024 16:46:43 GMT Cloud Enterprise

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title [gazebo] Add subtotals row on coverage page [gazebo] Add subtotals row on coverage page + test fix Jul 2, 2024
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Even whipped out the calculator to double check the sums in preview deploy 😂

@rohitvinnakota-codecov rohitvinnakota-codecov added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit bb4833d Jul 2, 2024
61 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/add-subtotal-row branch July 2, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants