fix: Session Expiration redirects for teams and enterprise #2889
Conversation
| @@ -10,6 +10,12 @@ const defaultConfig = { | |||
| GH_APP: 'codecov', | |||
| } | |||
|
|
|||
| export const LOCAL_STORAGE_SESSION_EXPIRED_KEY = 'expired-session' | |||
There was a problem hiding this comment.
moved these to shared consts for clarity and to remove all the redeclarations
| @@ -104,6 +104,7 @@ A.propTypes = { | |||
| variant: PropTypes.oneOf([ | |||
| 'default', | |||
| 'header', | |||
| 'guestHeader', | |||
There was a problem hiding this comment.
this was a propType fix error I was seeing in the console, unrelated to PR
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2889 +/- ##
==========================================
- Coverage 98.48% 98.47% -0.01%
==========================================
Files 878 878
Lines 13027 13023 -4
Branches 3489 3470 -19
==========================================
- Hits 12829 12825 -4
Misses 194 194
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2889 +/- ##
==========================================
- Coverage 98.48% 98.47% -0.01%
==========================================
Files 878 878
Lines 13027 13023 -4
Branches 3494 3493 -1
==========================================
- Hits 12829 12825 -4
Misses 194 194
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2889 +/- ##
=======================================
- Coverage 98.48 98.47 -0.01
=======================================
Files 878 878
Lines 13027 13023 -4
Branches 3489 3425 -64
=======================================
- Hits 12829 12825 -4
Misses 194 194
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 153 bytes ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2889 +/- ##
==========================================
- Coverage 98.48% 98.47% -0.01%
==========================================
Files 878 878
Lines 13027 13023 -4
Branches 3471 3470 -1
==========================================
- Hits 12829 12825 -4
Misses 194 194
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 153 bytes ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Description
A couple bug fixes in this PR, all centered around getting the session redirect to work properly for enterprise customers; and consequently non-enterprise customer regression fixes.
Fixes:
In the below videos we can see in the console the polling mechanism at play (I had to bump down the session expiry to a minute and the polling interval to 6 seconds to easily reproduce) for both enterprise and non-enterprise customers
Polling interval stuff in API is here: https://github.com/codecov/codecov-api/blob/c3f5e7f903c63f8a5eadc5a69a2846df57e65a0a/codecov_auth/views/github.py#L168
Screenshots
Screen.Recording.2024-05-20.at.2.21.03.PM.mov
Screen.Recording.2024-05-20.at.2.23.40.PM.mov
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.