Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add intro banner to bundle onboarding #2874

Merged
merged 5 commits into from
May 14, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented May 13, 2024

Description

Adds an intro banner to the BA onboarding page and also left aligns the page's layout to match designs. Radio button navigation to come next.

Part of codecov/engineering-team#1439

Screenshots

Before:

Screenshot 2024-05-13 at 16 18 36

After:

Screenshot 2024-05-14 at 10 27 25

@codecov-qa
Copy link

codecov-qa bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (34bbe06) to head (818ef90).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2874   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         879      880    +1     
  Lines       12954    12957    +3     
  Branches     3408     3469   +61     
=======================================
+ Hits        12758    12761    +3     
  Misses        192      192           
  Partials        4        4           
Files Coverage Δ
...e/BundlesTab/BundleOnboarding/BundleOnboarding.tsx 100.00% <ø> (ø)
...epoPage/BundlesTab/BundleOnboarding/IntroBlurb.tsx 100.00% <100.00%> (ø)
...oPage/CoverageOnboarding/IntroBlurb/IntroBlurb.tsx 100.00% <ø> (ø)
...rvices/navigation/useNavLinks/useStaticNavLinks.js 97.01% <100.00%> (+0.04%) ⬆️
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <100.00%> (+<0.01%) ⬆️
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34bbe06...818ef90. Read the comment docs.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.49%. Comparing base (34bbe06) to head (818ef90).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2874   +/-   ##
=====================================
  Coverage   98.49   98.49           
=====================================
  Files        879     880    +1     
  Lines      12954   12957    +3     
  Branches    3451    3469   +18     
=====================================
+ Hits       12758   12761    +3     
  Misses       192     192           
  Partials       4       4           
Files Coverage Δ
...e/BundlesTab/BundleOnboarding/BundleOnboarding.tsx 100.00% <ø> (ø)
...epoPage/BundlesTab/BundleOnboarding/IntroBlurb.tsx 100.00% <100.00%> (ø)
...oPage/CoverageOnboarding/IntroBlurb/IntroBlurb.tsx 100.00% <ø> (ø)
...rvices/navigation/useNavLinks/useStaticNavLinks.js 97.01% <100.00%> (+0.04%) ⬆️
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <100.00%> (+<0.01%) ⬆️
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34bbe06...818ef90. Read the comment docs.

Copy link

codecov-public-qa bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (34bbe06) to head (818ef90).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2874   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         879      880    +1     
  Lines       12954    12957    +3     
  Branches     3469     3409   -60     
=======================================
+ Hits        12758    12761    +3     
  Misses        192      192           
  Partials        4        4           
Files Coverage Δ
...e/BundlesTab/BundleOnboarding/BundleOnboarding.tsx 100.00% <ø> (ø)
...epoPage/BundlesTab/BundleOnboarding/IntroBlurb.tsx 100.00% <100.00%> (ø)
...oPage/CoverageOnboarding/IntroBlurb/IntroBlurb.tsx 100.00% <ø> (ø)
...rvices/navigation/useNavLinks/useStaticNavLinks.js 97.01% <100.00%> (+0.04%) ⬆️
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <100.00%> (+<0.01%) ⬆️
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34bbe06...818ef90. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2874   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         879      880    +1     
  Lines       12954    12957    +3     
  Branches     3469     3469           
=======================================
+ Hits        12758    12761    +3     
  Misses        192      192           
  Partials        4        4           
Files Coverage Δ
...e/BundlesTab/BundleOnboarding/BundleOnboarding.tsx 100.00% <ø> (ø)
...epoPage/BundlesTab/BundleOnboarding/IntroBlurb.tsx 100.00% <100.00%> (ø)
...oPage/CoverageOnboarding/IntroBlurb/IntroBlurb.tsx 100.00% <ø> (ø)
...rvices/navigation/useNavLinks/useStaticNavLinks.js 97.01% <100.00%> (+0.04%) ⬆️
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <100.00%> (+<0.01%) ⬆️
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34bbe06...818ef90. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented May 13, 2024

Bundle Report

Changes will increase total bundle size by 552 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.61MB 552 bytes ⬆️

Copy link

codecov bot commented May 13, 2024

Bundle Report

Changes will increase total bundle size by 552 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 6.61MB 552 bytes ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented May 13, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
a00eb67 Mon, 13 May 2024 20:29:05 GMT Expired Expired
818ef90 Tue, 14 May 2024 14:52:51 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/bundle-onboarding-overhaul-2 branch from a00eb67 to 818ef90 Compare May 14, 2024 14:27
@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review May 14, 2024 14:27
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 0a333f0 May 14, 2024
67 of 68 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/bundle-onboarding-overhaul-2 branch May 14, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants