chore: Remove/replace useCoverageWithFilters #2873

nicholas-codecov · 2024-05-13T18:58:55Z

Description

This PR actually removes the useCoverageWithFilters hook instead replacing it's use with the original hook and extending it to support the features that were specific to useCoverageWithFilters reducing the chances of actually creating a bug and difference between the two (we weren't fetching the same info for the same use 😬)

GH codecov/engineering-team#355

Notable Changes

Remove useCoverageWithFilters
Remove associated utils
Update useFileWithMainCoverage to support new cases
Update useCommitBasedCoverageForFileViewer to use useFileWithMainCoverage ... twice
Update imports
Update tests

codecov-qa · 2024-05-13T19:02:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (059a9bc) to head (5a7e61a).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2873      +/-   ##
==========================================
- Coverage   98.48%   98.47%   -0.01%     
==========================================
  Files         880      878       -2     
  Lines       13037    13026      -11     
  Branches     3491     3470      -21     
==========================================
- Hits        12839    12828      -11     
  Misses        194      194              
  Partials        4        4

Files	Coverage Δ
...rvices/file/useCommitBasedCoverageForFileViewer.ts	`100.00% <100.00%> (ø)`
...Contents/branch/file/usePrefetchBranchFileEntry.js	`100.00% <ø> (ø)`
...ontents/commit/file/usePrefetchCommitFileEntry.tsx	`100.00% <ø> (ø)`
src/services/pathContents/constants.ts	`100.00% <ø> (ø)`
...athContents/pull/file/usePrefetchPullFileEntry.tsx	`100.00% <ø> (ø)`
.../services/pathContents/useFileWithMainCoverage.tsx	`100.00% <100.00%> (ø)`
src/services/pathContents/utils.ts	`100.00% <100.00%> (ø)`
src/ui/CodeRenderer/SingleLine/SingleLine.jsx	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`54.54% <ø> (ø)`
Layouts	`97.26% <ø> (ø)`
Pages	`99.28% <ø> (ø)`
Services	`99.48% <100.00%> (-0.01%)`	⬇️
Shared	`99.68% <ø> (ø)`
UI	`94.53% <100.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 059a9bc...5a7e61a. Read the comment docs.

codecov-public-qa · 2024-05-13T19:02:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (059a9bc) to head (5a7e61a).

✅ All tests successful. No failed tests found ☺️

@@            Coverage Diff             @@
##             main    #2873      +/-   ##
==========================================
- Coverage   98.48%   98.47%   -0.01%     
==========================================
  Files         880      878       -2     
  Lines       13037    13026      -11     
  Branches     3473     3425      -48     
==========================================
- Hits        12839    12828      -11     
  Misses        194      194              
  Partials        4        4

Files	Coverage Δ
...rvices/file/useCommitBasedCoverageForFileViewer.ts	`100.00% <100.00%> (ø)`
...Contents/branch/file/usePrefetchBranchFileEntry.js	`100.00% <ø> (ø)`
...ontents/commit/file/usePrefetchCommitFileEntry.tsx	`100.00% <ø> (ø)`
src/services/pathContents/constants.ts	`100.00% <ø> (ø)`
...athContents/pull/file/usePrefetchPullFileEntry.tsx	`100.00% <ø> (ø)`
.../services/pathContents/useFileWithMainCoverage.tsx	`100.00% <100.00%> (ø)`
src/services/pathContents/utils.ts	`100.00% <100.00%> (ø)`
src/ui/CodeRenderer/SingleLine/SingleLine.jsx	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`54.54% <ø> (ø)`
Layouts	`97.26% <ø> (ø)`
Pages	`99.28% <ø> (ø)`
Services	`99.48% <100.00%> (-0.01%)`	⬇️
Shared	`99.68% <ø> (ø)`
UI	`94.53% <100.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 059a9bc...5a7e61a. Read the comment docs.

codecov-notifications · 2024-05-13T19:02:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #2873      +/-   ##
==========================================
- Coverage   98.48%   98.47%   -0.01%     
==========================================
  Files         880      878       -2     
  Lines       13037    13026      -11     
  Branches     3496     3425      -71     
==========================================
- Hits        12839    12828      -11     
  Misses        194      194              
  Partials        4        4

Files	Coverage Δ
...rvices/file/useCommitBasedCoverageForFileViewer.ts	`100.00% <100.00%> (ø)`
...Contents/branch/file/usePrefetchBranchFileEntry.js	`100.00% <ø> (ø)`
...ontents/commit/file/usePrefetchCommitFileEntry.tsx	`100.00% <ø> (ø)`
src/services/pathContents/constants.ts	`100.00% <ø> (ø)`
...athContents/pull/file/usePrefetchPullFileEntry.tsx	`100.00% <ø> (ø)`
.../services/pathContents/useFileWithMainCoverage.tsx	`100.00% <100.00%> (ø)`
src/services/pathContents/utils.ts	`100.00% <100.00%> (ø)`
src/ui/CodeRenderer/SingleLine/SingleLine.jsx	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`54.54% <ø> (ø)`
Layouts	`97.26% <ø> (ø)`
Pages	`99.28% <ø> (ø)`
Services	`99.48% <100.00%> (-0.01%)`	⬇️
Shared	`99.68% <ø> (ø)`
UI	`94.53% <100.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 059a9bc...5a7e61a. Read the comment docs.

codecov-staging · 2024-05-13T19:04:06Z

Bundle Report

Changes will decrease total bundle size by 599 bytes ⬇️

Bundle name	Size	Change
gazebo-staging-array-push	6.61MB	599 bytes ⬇️

codecov · 2024-05-13T19:05:05Z

Bundle Report

Changes will decrease total bundle size by 599 bytes ⬇️

Bundle name	Size	Change
gazebo-production-array-push	6.61MB	599 bytes ⬇️

codecov · 2024-05-13T19:06:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (059a9bc) to head (5a7e61a).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #2873   +/-   ##
=====================================
  Coverage   98.48   98.48           
=====================================
  Files        880     878    -2     
  Lines      13037   13026   -11     
  Branches    3429    3493   +64     
=====================================
- Hits       12839   12828   -11     
  Misses       194     194           
  Partials       4       4

Files	Coverage Δ
...rvices/file/useCommitBasedCoverageForFileViewer.ts	`100.00% <100.00%> (ø)`
...Contents/branch/file/usePrefetchBranchFileEntry.js	`100.00% <ø> (ø)`
...ontents/commit/file/usePrefetchCommitFileEntry.tsx	`100.00% <ø> (ø)`
src/services/pathContents/constants.ts	`100.00% <ø> (ø)`
...athContents/pull/file/usePrefetchPullFileEntry.tsx	`100.00% <ø> (ø)`
.../services/pathContents/useFileWithMainCoverage.tsx	`100.00% <100.00%> (ø)`
src/services/pathContents/utils.ts	`100.00% <100.00%> (ø)`
src/ui/CodeRenderer/SingleLine/SingleLine.jsx	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`54.54% <ø> (ø)`
Layouts	`97.26% <ø> (ø)`
Pages	`99.28% <ø> (ø)`
Services	`99.48% <100.00%> (-0.01%)`	⬇️
Shared	`99.68% <ø> (ø)`
UI	`94.53% <100.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 059a9bc...5a7e61a. Read the comment docs.

codecov-releaser · 2024-05-13T19:08:54Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit	Created	Cloud	Enterprise
`eb9eca4`	Mon, 13 May 2024 19:08:54 GMT	Expired	Expired
`5a7e61a`	Thu, 16 May 2024 11:36:03 GMT	Cloud	Enterprise

ajay-sentry · 2024-05-15T23:41:43Z

src/services/pathContents/utils.ts

@@ -14,7 +14,7 @@ export function extractCoverageFromResponse(
  if (!coverageFile) return null
  const lineWithCoverage = keyBy(coverageFile?.coverage, 'line')
  const fileCoverage = mapValues(lineWithCoverage, 'coverage')
-  const coverageTotal = coverageFile?.totals?.coverage


was this a bug fix too?

Nope, i had originally aliased the field in GQL, this is me removing it now and updating it, with TS makes it easier to find the errors

nice! love it

ajay-sentry

seems legit, send it

…ts are selected and migrate to TS

…overage

…pping up

ajay-sentry reviewed May 15, 2024

View reviewed changes

ajay-sentry approved these changes May 15, 2024

View reviewed changes

nicholas-codecov added 9 commits May 16, 2024 08:20

remove useCoverageWithFilters hook

9fdcbfc

update useFileWithMainCoverage to handle cases when flags or componen…

a33df0b

…ts are selected and migrate to TS

small TS refactors

da4a048

grab component names, as well use percentCovered directly now

8905df0

remove redundent extractCoverageFromResponse function

8c48fa1

update useCommitBasedCoverageForFileViewer to re-use useFileWithMainC…

4da4452

…overage

update imports

9311a37

fix React key error in SingleLine component as this was constantly po…

1ce66ad

…pping up

test updates

5a7e61a

nicholas-codecov force-pushed the gh-eng-355-remove-repository-deprecated-from-use-coverage-with-filters branch from eb9eca4 to 5a7e61a Compare May 16, 2024 11:24

nicholas-codecov added this pull request to the merge queue May 16, 2024

Merged via the queue into main with commit c1a8e81 May 16, 2024
57 of 60 checks passed

nicholas-codecov deleted the gh-eng-355-remove-repository-deprecated-from-use-coverage-with-filters branch May 16, 2024 15:25

RulaKhaled pushed a commit that referenced this pull request May 16, 2024

chore: Remove/replace useCoverageWithFilters (#2873)

ab8f7bb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Remove/replace useCoverageWithFilters #2873

chore: Remove/replace useCoverageWithFilters #2873

nicholas-codecov commented May 13, 2024

codecov-qa bot commented May 13, 2024 •

edited

Loading

codecov-public-qa bot commented May 13, 2024 •

edited

Loading

codecov-notifications bot commented May 13, 2024 •

edited

Loading

codecov-staging bot commented May 13, 2024 •

edited

Loading

codecov bot commented May 13, 2024 •

edited

Loading

codecov bot commented May 13, 2024 •

edited

Loading

codecov-releaser commented May 13, 2024 •

edited

Loading

ajay-sentry May 15, 2024

nicholas-codecov May 16, 2024

ajay-sentry May 16, 2024

ajay-sentry left a comment

chore: Remove/replace useCoverageWithFilters #2873

chore: Remove/replace useCoverageWithFilters #2873

Conversation

nicholas-codecov commented May 13, 2024

Description

Notable Changes

codecov-qa bot commented May 13, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented May 13, 2024 • edited Loading

Codecov Report

codecov-notifications bot commented May 13, 2024 • edited Loading

Codecov Report

codecov-staging bot commented May 13, 2024 • edited Loading

Bundle Report

codecov bot commented May 13, 2024 • edited Loading

Bundle Report

codecov bot commented May 13, 2024 • edited Loading

Codecov Report

codecov-releaser commented May 13, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

ajay-sentry May 15, 2024

Choose a reason for hiding this comment

nicholas-codecov May 16, 2024

Choose a reason for hiding this comment

ajay-sentry May 16, 2024

Choose a reason for hiding this comment

ajay-sentry left a comment

Choose a reason for hiding this comment

codecov-qa bot commented May 13, 2024 •

edited

Loading

codecov-public-qa bot commented May 13, 2024 •

edited

Loading

codecov-notifications bot commented May 13, 2024 •

edited

Loading

codecov-staging bot commented May 13, 2024 •

edited

Loading

codecov bot commented May 13, 2024 •

edited

Loading

codecov bot commented May 13, 2024 •

edited

Loading

codecov-releaser commented May 13, 2024 •

edited

Loading