Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Convert RepositoryDeprecated to Repository in useRepoCoverage #2864

Merged
merged 6 commits into from
May 14, 2024
Merged

ref: Convert RepositoryDeprecated to Repository in useRepoCoverage #2864

merged 6 commits into from
May 14, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented May 8, 2024 •
edited
Loading

Converts RepositoryDeprecated use to Repository in uesRepoCoverage hook's query.

Also, a bunch of TS conversions because was having type issues and this seemed like the best solution at the time (it wasn't lol).

@codecov-staging
Copy link

codecov-staging bot commented May 8, 2024 •
edited by codecov-notifications bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2864   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         880      880           
  Lines       12989    13007   +18     
  Branches     3416     3420    +4     
=======================================
+ Hits        12791    12809   +18     
  Misses        194      194           
  Partials        4        4
Files Coverage Δ
.../pages/RepoPage/CoverageTab/Summary/utils/paths.ts 100.00% <100.00%> (ø)
...ge/CoverageTab/SummaryTeamPlan/SummaryTeamPlan.tsx 100.00% <100.00%> (ø)
...es/RepoPage/CoverageTab/hooks/useBranchSelector.ts 100.00% <100.00%> (ø)
...ge/CoverageTab/summaryHooks/useCoverageRedirect.ts 100.00% <100.00%> (ø)
...es/RepoPage/CoverageTab/summaryHooks/useSummary.ts 100.00% <100.00%> (ø)
src/pages/RepoPage/utils/paths.ts 100.00% <100.00%> (ø)
src/services/repo/useRepoCoverage.tsx 100.00% <100.00%> (ø)
...c/shared/ContentsTable/utils/adjustListIfUpDir.tsx 100.00% <ø> (ø)
src/shared/utils/url.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <100.00%> (+<0.01%) ⬆️
Services 99.48% <100.00%> (+<0.01%) ⬆️
Shared 99.68% <100.00%> (+<0.01%) ⬆️
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0229954...2dfee42. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented May 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (0229954) to head (2dfee42).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2864   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         880      880           
  Lines       12989    13007   +18     
  Branches     3459     3481   +22     
=======================================
+ Hits        12791    12809   +18     
  Misses        194      194           
  Partials        4        4
Files Coverage Δ
.../pages/RepoPage/CoverageTab/Summary/utils/paths.ts 100.00% <100.00%> (ø)
...ge/CoverageTab/SummaryTeamPlan/SummaryTeamPlan.tsx 100.00% <100.00%> (ø)
...es/RepoPage/CoverageTab/hooks/useBranchSelector.ts 100.00% <100.00%> (ø)
...ge/CoverageTab/summaryHooks/useCoverageRedirect.ts 100.00% <100.00%> (ø)
...es/RepoPage/CoverageTab/summaryHooks/useSummary.ts 100.00% <100.00%> (ø)
src/pages/RepoPage/utils/paths.ts 100.00% <100.00%> (ø)
src/services/repo/useRepoCoverage.tsx 100.00% <100.00%> (ø)
...c/shared/ContentsTable/utils/adjustListIfUpDir.tsx 100.00% <ø> (ø)
src/shared/utils/url.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <100.00%> (+<0.01%) ⬆️
Services 99.48% <100.00%> (+<0.01%) ⬆️
Shared 99.68% <100.00%> (+<0.01%) ⬆️
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0229954...2dfee42. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented May 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (0229954) to head (2dfee42).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2864   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         880      880           
  Lines       12989    13007   +18     
  Branches     3417     3420    +3     
=======================================
+ Hits        12791    12809   +18     
  Misses        194      194           
  Partials        4        4
Files Coverage Δ
.../pages/RepoPage/CoverageTab/Summary/utils/paths.ts 100.00% <100.00%> (ø)
...ge/CoverageTab/SummaryTeamPlan/SummaryTeamPlan.tsx 100.00% <100.00%> (ø)
...es/RepoPage/CoverageTab/hooks/useBranchSelector.ts 100.00% <100.00%> (ø)
...ge/CoverageTab/summaryHooks/useCoverageRedirect.ts 100.00% <100.00%> (ø)
...es/RepoPage/CoverageTab/summaryHooks/useSummary.ts 100.00% <100.00%> (ø)
src/pages/RepoPage/utils/paths.ts 100.00% <100.00%> (ø)
src/services/repo/useRepoCoverage.tsx 100.00% <100.00%> (ø)
...c/shared/ContentsTable/utils/adjustListIfUpDir.tsx 100.00% <ø> (ø)
src/shared/utils/url.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <100.00%> (+<0.01%) ⬆️
Services 99.48% <100.00%> (+<0.01%) ⬆️
Shared 99.68% <100.00%> (+<0.01%) ⬆️
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0229954...2dfee42. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented May 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (0229954) to head (2dfee42).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2864   +/-   ##
=====================================
  Coverage   98.48   98.48           
=====================================
  Files        880     880           
  Lines      12989   13007   +18     
  Branches    3482    3463   -19     
=====================================
+ Hits       12791   12809   +18     
  Misses       194     194           
  Partials       4       4
Files Coverage Δ
.../pages/RepoPage/CoverageTab/Summary/utils/paths.ts 100.00% <100.00%> (ø)
...ge/CoverageTab/SummaryTeamPlan/SummaryTeamPlan.tsx 100.00% <100.00%> (ø)
...es/RepoPage/CoverageTab/hooks/useBranchSelector.ts 100.00% <100.00%> (ø)
...ge/CoverageTab/summaryHooks/useCoverageRedirect.ts 100.00% <100.00%> (ø)
...es/RepoPage/CoverageTab/summaryHooks/useSummary.ts 100.00% <100.00%> (ø)
src/pages/RepoPage/utils/paths.ts 100.00% <100.00%> (ø)
src/services/repo/useRepoCoverage.tsx 100.00% <100.00%> (ø)
...c/shared/ContentsTable/utils/adjustListIfUpDir.tsx 100.00% <ø> (ø)
src/shared/utils/url.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <100.00%> (+<0.01%) ⬆️
Services 99.48% <100.00%> (+<0.01%) ⬆️
Shared 99.68% <100.00%> (+<0.01%) ⬆️
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0229954...2dfee42. Read the comment docs.

@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/repository-deprecated-useRepoCoverage branch from f5d46ad to 13171af Compare May 9, 2024 14:34
@codecov-staging
Copy link

codecov-staging bot commented May 9, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 18.87kB ⬇️

Bundle name Size Change
gazebo-staging-array-push 6.59MB 18.87kB ⬇️

@codecov Codecov
Copy link

codecov bot commented May 9, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 18.87kB ⬇️

Bundle name Size Change
gazebo-production-array-push 6.59MB 18.87kB ⬇️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented May 9, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
13171af Thu, 09 May 2024 14:45:02 GMT Expired Expired
4cec898 Thu, 09 May 2024 19:13:27 GMT Expired Expired
4cec898 Thu, 09 May 2024 19:18:51 GMT Expired Expired
61370b2 Fri, 10 May 2024 03:17:17 GMT Expired Expired
79f5f53 Fri, 10 May 2024 19:48:57 GMT Expired Expired
79f5f53 Fri, 10 May 2024 19:56:51 GMT Expired Expired
2dfee42 Tue, 14 May 2024 18:44:23 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/repository-deprecated-useRepoCoverage branch 4 times, most recently from 61370b2 to fa41476 Compare May 10, 2024 19:36
@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review May 10, 2024 20:15
@spalmurray-codecov spalmurray-codecov changed the title Convert RepositoryDeprecated to Repository in useRepoCoverage ref: Convert RepositoryDeprecated to Repository in useRepoCoverage May 13, 2024
@nicholas-codecov nicholas-codecov self-requested a review May 14, 2024 14:43
nicholas-codecov
nicholas-codecov reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments

src/pages/RepoPage/CoverageTab/SummaryTeamPlan/SummaryTeamPlan.tsx Show resolved Hide resolved
src/pages/RepoPage/CoverageTab/summaryHooks/useCoverageRedirect.spec.tsx Outdated Show resolved Hide resolved
src/pages/RepoPage/CoverageTab/summaryHooks/useSummary.ts Show resolved Hide resolved
src/services/repo/useRepoCoverage.spec.tsx Outdated Show resolved Hide resolved
src/services/repo/useRepoCoverage.spec.tsx Show resolved Hide resolved
@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/repository-deprecated-useRepoCoverage branch from 79f5f53 to 2dfee42 Compare May 14, 2024 18:33
@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue May 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2024
@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 521e89b May 14, 2024
59 of 60 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/repository-deprecated-useRepoCoverage branch May 14, 2024 18:59
RulaKhaled pushed a commit that referenced this pull request May 16, 2024
@spalmurray-codecov @RulaKhaled
ref: Convert RepositoryDeprecated to Repository in useRepoCoverage (#…
033d878 
…2864)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholas-codecov nicholas-codecov nicholas-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spalmurray-codecov @codecov-releaser @nicholas-codecov