Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove New Repo Setup Flag and Hide Setup Repo Link #1650

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

nicholas-codecov
Copy link
Contributor

Description

Since the new repo flag has been rolled out to 100% it's probably time that we can get rid of it in the codebase. This PR includes the removal of that flag, as well as removing the Setup Repo link for users who do not belong to the organization.

Notable Changes

  • Add user belongs to org check in ReposTable
  • Add a few optional chaining checks
  • Remove flag related tests
  • Refactor of ReposTables tests to mock endpoints instead of hooks

Guest user:

Screen Shot 2022-10-17 at 9 39 05 AM

Signed in user:

Screen Shot 2022-10-17 at 9 39 26 AM

@netlify
Copy link

netlify bot commented Oct 17, 2022

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 797a2bf
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/634d5e917440160009475831
😎 Deploy Preview https://deploy-preview-1650--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #1650 (8526dce) into main (8397b61) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8526dce differs from pull request most recent head 797a2bf. Consider uploading reports for the commit 797a2bf to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1650   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files         488      488           
  Lines        5606     5631   +25     
  Branches     1419     1427    +8     
=======================================
+ Hits         5568     5593   +25     
  Misses         38       38           
Impacted Files Coverage Δ
src/shared/ListRepo/ReposTable/ReposTable.jsx 100.00% <100.00%> (ø)
src/services/pull/usePull.js 100.00% <0.00%> (ø)
src/services/user/useOnboardUser.js 100.00% <0.00%> (ø)
src/services/navigation/useNavLinks.js 100.00% <0.00%> (ø)
src/pages/PullRequestPage/Flags/Flags.jsx 100.00% <0.00%> (ø)
src/pages/PullRequestPage/Commits/Commits.jsx 100.00% <0.00%> (ø)
src/pages/PullRequestPage/PullRequestPage.jsx 100.00% <0.00%> (ø)
src/layouts/UserOnboarding/UserOnboardingForm.jsx 100.00% <0.00%> (ø)
src/layouts/UserOnboarding/UserOnboardingModal.jsx 100.00% <0.00%> (ø)
...rc/layouts/UserOnboarding/OrganizationSelector.jsx 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8397b61...797a2bf. Read the comment docs.

Copy link
Contributor

@terry-codecov terry-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Full disclosure I did not comb through the test changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants