Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve assertion approaches #24

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Improve assertion approaches #24

merged 2 commits into from
Sep 25, 2023

Conversation

peter279k
Copy link
Contributor

Changed log

  • According to the official PHPUnit document, it should be assertEquals($expected, $actual). The parameters position should be changed.
  • Remove the comment about dividing error assertion.

@thomasrockhu-codecov
Copy link
Contributor

@peter279k thanks for this! I added back in the comment for the last test as it helps to show an uncovered line in the UI

@thomasrockhu-codecov thomasrockhu-codecov merged commit f3a2ef0 into codecov:main Sep 25, 2023
1 check passed
@peter279k peter279k deleted the improve_tests branch September 26, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasrockhu-codecov thomasrockhu-codecov thomasrockhu-codecov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter279k @thomasrockhu-codecov