Add support for Jenkins Blue Ocean #56
Conversation
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 95.65% 95.79% +0.14%
==========================================
Files 17 18 +1
Lines 230 238 +8
Branches 45 46 +1
==========================================
+ Hits 220 228 +8
Misses 10 10
Continue to review full report at Codecov.
|
|
Very nice job @rochdev Thank you! |
lib/git.js
Outdated
| }, | ||
|
|
||
| head: function(){ | ||
| return execSync("git rev-parse HEAD || hg id -i --debug | tr -d '+'").toString().trim(); |
There was a problem hiding this comment.
Recommended change:
- return execSync("git rev-parse HEAD || hg id -i --debug | tr -d '+'").toString().trim()
+ return execSync("git log -1 --pretty=%B || hg id -i --debug | tr -d '+'").toString().trim()There was a problem hiding this comment.
@stevepeak This change seems to return the commit message instead of the commit ID.
|
Should I add Blue Ocean to the README? It might be confusing if different codecov implementations have different levels of support for Jenkins that is not documented. |
|
Looks good @rochdev @stevepeak Do the other uploaders support Blue Ocean? If not we can add it to them |
|
@stevepeak @eddiemoore What is the next step to have this move forward? |
|
@eddiemoore Other uploaders should support Blue Ocean by using |
|
Given the change to |
rochdev
force-pushed
the
blue-ocean
branch
2 times, most recently
from
0530519 to
0436212
Compare
|
Looks good to me. @stevepeak All ok with you? |
|
Yes, thank you @eddiemoore. |
closes #55