dev: Add Ruff print rules to API (T20) #1107
Conversation
| @@ -50,5 +50,5 @@ def execute(self, owner, current_owner): | |||
| owner.add_admin(current_owner) | |||
| return isAdmin or (current_owner.ownerid in admins) | |||
| except Exception as error: | |||
| print("Error Calling Admin Provider " + repr(error)) | |||
| print("Error Calling Admin Provider " + repr(error)) # noqa: T201 | |||
There was a problem hiding this comment.
I ignored removing all the prints for the django commands
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1107 +/- ##
==========================================
+ Coverage 96.10% 96.11% +0.01%
==========================================
Files 835 835
Lines 19576 19572 -4
==========================================
- Hits 18813 18812 -1
+ Misses 763 760 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
This PR aims to add the ruff print rules to API, and either removes or ignores each print statement (I just used my best judgement)
Ruff rules can be found here: https://docs.astral.sh/ruff/rules/#flake8-print-t20
Closes codecov/engineering-team#3279
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.