Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Receive user name for new Terms of Service UI #1094

Merged
merged 14 commits into from
Jan 22, 2025

Conversation

calvin-codecov
Copy link
Contributor

@calvin-codecov calvin-codecov commented Jan 13, 2025

Purpose/Motivation

What is the feature? Why is this being done?

New onboarding changes for pre-PAT appless to make it easier and more clear for users to sign up. We are changing up the required information that a user must fill out to complete onboarding. We will no longer be asking for customer intent and for the user to select a default organization in step that follows this screen.

Links to relevant tickets

codecov/engineering-team#3174

Changes related to the UI changes designated in this Figma: https://www.figma.com/design/SsoxtY2SB73l0wiLbJ8FhZ/GH-2092?node-id=2288-16704&t=sMCRUMT3J1bwIct1-1

What does this PR do?

For the onboarding page, we are:

  • adding name input and requiring it
  • newly requiring email input (previously only required when user was opting into marketing updates)
  • no longer asking for customer intent (Personal or Business)

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@calvin-codecov calvin-codecov requested a review from a team as a code owner January 13, 2025 22:29
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (b4cc89d) to head (89729df).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1094   +/-   ##
=======================================
  Coverage   96.09%   96.10%           
=======================================
  Files         835      835           
  Lines       19556    19576   +20     
=======================================
+ Hits        18793    18813   +20     
  Misses        763      763           
Flag Coverage Δ
unit 96.01% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

codecov-staging bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jan 13, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2706 1 2705 7
View the top 1 failed tests by shortest run time
codecov_auth/commands/owner/interactors/tests/test_save_terms_agreement.py::UpdateSaveTermsAgreementInteractorTest::test_validation_error_when_name_invalid
Stack Traces | 0.323s run time
self = <codecov_auth.commands.owner.interactors.tests.test_save_terms_agreement.UpdateSaveTermsAgreementInteractorTest testMethod=test_validation_error_when_name_invalid>

    def test_validation_error_when_name_invalid(self):
>       with pytest.raises(ValidationError):
E       Failed: DID NOT RAISE <class 'codecov.commands.exceptions.ValidationError'>

.../interactors/tests/test_save_terms_agreement.py:210: Failed

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link
Contributor

github-actions bot commented Jan 13, 2025

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link

codecov-public-qa bot commented Jan 13, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2707 1 2706 6
View the top 1 failed tests by shortest run time
codecov_auth/commands/owner/interactors/tests/test_save_terms_agreement.py::UpdateSaveTermsAgreementInteractorTest::test_validation_error_when_name_invalid
Stack Traces | 0.323s run time
self = <codecov_auth.commands.owner.interactors.tests.test_save_terms_agreement.UpdateSaveTermsAgreementInteractorTest testMethod=test_validation_error_when_name_invalid>

    def test_validation_error_when_name_invalid(self):
>       with pytest.raises(ValidationError):
E       Failed: DID NOT RAISE <class 'codecov.commands.exceptions.ValidationError'>

.../interactors/tests/test_save_terms_agreement.py:210: Failed

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@calvin-codecov calvin-codecov changed the title feat: Receive user name instead of customer intent for new terms UI feat: Receive user name for new Terms of Service UI Jan 17, 2025
@calvin-codecov calvin-codecov added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 914b22c Jan 22, 2025
19 checks passed
@calvin-codecov calvin-codecov deleted the cy/accept_name_tos branch January 22, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants