-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 upgrade - can't get coverage to show up - unusable report error #1284
Comments
@thomasrockhu-codecov Retried worked (past that 502) but now back to "unusable report" info - 2024-02-09 20:45:56,383 -- Your upload is now processing. When finished, results will be available at: https://app.codecov.io/github/fortio/fortio/commit/88cbb9365d06f05d152266366aff6846ed9c98d9 |
Thoughts? |
@ldemailly taking a look |
Seems like same issue as codecov/codecov-action#1284
ping? https://app.codecov.io/gh/fortio/fortio/commits dropped to 0% as a result |
Another one despite using 4.0.2 of the action: https://app.codecov.io/github/fortio/fortio/commit/a3a4496ae4f8dfc42ba9577d49f44537f00a30aa seems the issue is a mix of plain text and compressed coverage in the report:
[...]
, 386, 387, 394, 398, 399, 400, 401, 406, 407, 410, 411, 414, 415, 419, 420, 422, 423, 424, 425, 430, 436, 437, 438, 440, 444, 454, 455, 460, 462, 463, 464, 468, 471, 476, 479, 485, 488, 489, 494, 497]}, "version/version.go": {"eof": null, "lines": [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 21, 23, 28, 29, 30, 31, 32, 33, 36, 37, 38, 39, 42, 43, 44, 45, 48, 49, 50, 51, 54]}}}, "network_files": [".circleci/config.yml", ".circleci/coverage.sh", ".github/dependabot.yml", ".github/workflows/codecov.yml", ".github/workflows/codeql-analysis.yml", ".github/workflows/main.yml", ".github/workflows/manual-build.yml", ".github/workflows/test.yml", ".gitignore", ".golangci.yml", ".testdata/payloadTest1.txt", "CONTRIBUTING.md", "Dockerfile", "Dockerfile.build", "Dockerfile.echosrv", "Dockerfile.fcurl", "LICENSE", "Makefile", "README.md", "SECURITY.md", "Webtest.sh", "bincommon/commonflags.go", "cert-gen", "cli/fortio_main.go", "cli_test.go", "cli_test.txtar", "codecov.yml", "debian/changelog", "debian/compat", "debian/control", "debian/copyright", "debian/rules", "debian/source/format", "debian/source/lintian-overrides", "dflag/README.md", "dflag/dflag.go", "docs/fortio-logo-color.png", "docs/fortio-logo.gvdesign", "docs/fortio-logo.svg", "docs/fortio.1", "echosrv/echo.go", "fcurl/fcurl.go", "fgrpc/grpcrunner.go", "fgrpc/grpcrunner_test.go", "fgrpc/ping.pb.go", "fgrpc/ping.proto", "fgrpc/pingsrv.go", "fgrpc/pingsrv_test.go", "fhttp/http_client.go", "fhttp/http_forwarder.go", "fhttp/http_forwarder_test.go", "fhttp/http_loglevel_test.go", "fhttp/http_server.go", "fhttp/http_test.go", "fhttp/http_utils.go", "fhttp/httprunner.go", "fhttp/httprunner_test.go", "fhttp/https_server_test.go", "fnet/network.go", "fnet/network_norace_test.go", "fnet/network_stdin_test.go", "fnet/network_test.go", "go.mod", "go.sum", "histogram/main.go", "jrpc/jrpcClient.go", "jrpc/jrpcServer.go", "jrpc/jrpc_test.go", "log/logger.go", "main.go", "metrics/Makefile", "metrics/metrics.go", "metrics/prometheus.yml", "periodic/periodic.go", "periodic/periodic_loglevel_test.go", "periodic/periodic_test.go", "rapi/data.go", "rapi/restHandler.go", "rapi/restHandler_test.go", "release/.gitignore", "release/Dockerfile.in", "release/Makefile.dist", "release/README.md", "release/bumpRelease.sh", "release/ffpm.sh", "release/release.sh", "release/updateFlags.sh", "stats/stats.go", "stats/stats_test.go", "tcprunner/tcprunner.go", "tcprunner/tcprunner_test.go", "udprunner/udprunner.go", "udprunner/udprunner_test.go", "ui/static/css/fortio.css", "ui/static/img/favicon.ico", "ui/static/img/fortio-logo-gradient-no-bg.svg", "ui/static/img/fortio-logo-white-bg.svg", "ui/static/img/fortio-logo-white-on-gradient.svg", "ui/static/img/fortio-logo.svg", "ui/static/img/logo.svg", "ui/static/js/Chart.min.js", "ui/static/js/fortio_chart.js", "ui/templates/browse.html", "ui/templates/header.html", "ui/templates/main.html", "ui/templates/sync.html", "ui/uihandler.go", "version/version.go"], "coverage_files": [{"filename": "/home/runner/work/fortio/fortio/coverage.txt", "format": "base64+compressed", "data": "eJylnc22LDeOnef1FPcBYmUF/8maeuK5H8BLltRl2VWS1i1V9+sbe4N5TpxMMhOQBx1H1Su+i0gGgz8gsPGXf/72089/+/bDH7/985cf//Ifv33/45ffbr99//tf9T//+s8ffvn19vff/hbjLaQj5lv8Fr6dr25st9COdMqN8Vv+y5d//v/7fzyb/Y+/f//9x7/i8v3fv/7683c8Qo63Mo6cby3LM4QzWzkQR67yA4Qr1YoBOHK/ZWmaaIXGLR3lvHU8YrE+YQm3fpR0S2IpdyskL+0o5ZZOtob1CUkcpd1G55s0Urj/KIONYYVqkCes6Rbqt+R4QhJHLWyOVZ9cQhW25JV1gey2er+FMxxD2j5/K99CjtYfR+QY+pTd+pgDj4nLicd0WANyjE5r4TzN9rr0LPmFt1DkHdjtKSJkvqEnp2o1GE78wnA2vPXo+YnKHCEE+ZHpWzVzIcJiSLeCHh0cz0pGUH2JLpK/
[...]
|
ps: wanted to downgrade to v3 meanwhile but getting [2024-03-06T12:12:34.707Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Could not find a repository associated with upload token ***', code='not_found')} my CODECOV_TOKEN works with v4 (well however much v4 works) |
removing the token (!) v3 finally passed and the format is quite different I hope v3 will stay working very long and v4 is fixed as well (including token weirdness) - thanks @rohan-at-sentry |
* switch to go 1.21.8 and prep for 1.63.4 * revert codecov action to v3 until codecov/codecov-action#1284 is fixed
@rohan-at-sentry I hope everything is ok with you - any update? |
@ldemailly my apologies - This dropped of my radar! @thomasrockhu @drazisil-codecov can you help out here? |
@ldemailly, apologies, I'm not quite understanding the issue right now. Is it that when you bump to v4 that you are getting an We have since made some changes to the underlying CLI, would you be able to try it again? |
I changed how I gather coverage, I used to do it package by package this way:
and maybe that was creating the mix up above, or you fixed something because now it works with my simpler/more direct coverage This being said... I'd rather not have to change a dozen repos to add
why is that now (in v4) needed for public repos? |
@ldemailly glad to hear things are now working. I'm closing this issue out for now, please let us know if this persists. Re
with v4 we made uploading to Codecov with a token mandatory to make uploads and processing more reliable and secure. |
Also note that failure "passes" the build which... avoids that this is blocking but also defeats the point of checking coverage
Newest error:
https://github.com/fortio/fortio/actions/runs/7848651386/job/21420245264?pr=886
and earlier:
unusable report
but then that gives
Originally posted by @ldemailly in #1248 (comment)
The text was updated successfully, but these errors were encountered: