Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XML comments to all public members #561

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

Shane32
Copy link
Contributor

@Shane32 Shane32 commented Jun 2, 2024

Summary

This PR adds XML comments to all public members

No code has been changed.

Test Plan

CS1591 is enforced so any public members added in the future will require XML comments or will break the build.

Notes

These xml comments may not be perfect, but they're better than nothing. Please suggest any changes desired.

Copy link
Owner

@codebude codebude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that looks like a lot of work. Thanks! Before merging I kindly ask you to fix the test cases, too.

QRCoder/PayloadGenerator/Girocode.cs Show resolved Hide resolved
@codebude codebude merged commit d7b9c81 into codebude:master Jun 3, 2024
3 checks passed
@Shane32 Shane32 deleted the xml_comments branch June 3, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants