Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to add an example tab to showcase the size #4

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

juneate
Copy link

@juneate juneate commented Dec 6, 2021

Added an "Example" tab for demonstration. The font-size is set from the string value passed as a prop in index.svelte, computed using clampValue. May want to recompute here for precision.

@vercel
Copy link

vercel bot commented Dec 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/codeadrian/modern-fluid-typography-editor/5f3QWZdRYqkSbaE73KNfbsshZDBQ
✅ Preview: https://modern-fluid-typography-editor-git-fork-junea-3b9b1a-codeadrian.vercel.app

@codeAdrian
Copy link
Owner

Hi @juneate
Thank you very much for your contribution. I like the idea of a preview screen. I'll review the PR as soon as possible and report back.

I've changed the target branch to develop, so we can use master only for hotfixes and releases in a regular interval.

Thanks once again!

@codeAdrian
Copy link
Owner

Hi @juneate, I think this is a good starting point for the preview feature. It would be awesome if the preview could also take Root Font Size value into account.

Additionally, I would like it to have more functionality.

First off, It would be more beneficial for both desktop and mobile users to have a range input and a regular text input so they can set the screen size manually without the need to resize the window or the container.

Second, it would be even more beneficial to explore the accessibility implications of the fluid font - how the user zoom affects the perceived font size.

Let me know what you think.

Thanks,
Adrian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants