start: Add log with VM's IP when it started #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be useful to detect some `crc start` issues early, and is not always present in the debug log at the moment. This is related to crc-org#2214
praveenkumar
approved these changes
Apr 14, 2021
| @@ -277,6 +277,7 @@ func (client *client) Start(ctx context.Context, startConfig types.StartConfig) | |||
| if err != nil { | |||
| return nil, errors.Wrap(err, "Error getting the IP") | |||
| } | |||
| logging.Infof("CodeReady Containers instance is running with IP %s", instanceIP) | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be useful to detect some
crc startissues early, and is notalways present in the debug log at the moment.
This is related to #2214