Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: split eslint e2e #871

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

test: split eslint e2e #871

wants to merge 43 commits into from

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Nov 9, 2024

This PR moves all plugin-eslint related e2e tests into a separate project and uses a new project eslint-e2e-env to maintain the static files

@github-actions github-actions bot added 🔬 testing writing tests 🦾 CI/CD continuous integration and deployment 🛠️ tooling labels Nov 9, 2024
Copy link

github-actions bot commented Nov 9, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit ea4cf71 with source commit 7e6c29d.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Security 🟡 88 🟡 73 ↓ −14.7
Performance 🟡 54 🟡 56 ↑ +2.5
Custom checks 🟡 67 🟡 67
Code coverage 🟡 90 🟡 90
Updates 🟡 76 🟡 76
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 3 audits regressed, 16 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JS Packages NPM audit 🟡 88 🟡 73 ↓ −14.7
Lighthouse Performance 🟡 54 🟡 56 ↑ +2.5

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JS Packages Vulnerabilities for NPM dev dependencies. 🟨 22 vulnerabilities (22 low) 🟥 26 vulnerabilities (4 high, 22 low) ↑ +18.2 %
Lighthouse Speed Index 🟥 6.8 s 🟨 5.6 s ↓ −16.9 %
JS Packages Vulnerabilities for NPM prod dependencies. 🟩 3 vulnerabilities (3 low) 🟨 4 vulnerabilities (1 high, 3 low) ↑ +33.3 %
Lighthouse First Contentful Paint 🟨 2.8 s 🟨 2.6 s ↓ −7.3 %
Lighthouse Time to Interactive 🟥 14.6 s 🟥 16.0 s ↑ +9.9 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 28 resources found ↑ +1.2 %
Lighthouse Total Blocking Time 🟥 4,740 ms 🟥 7,610 ms ↑ +60.6 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,820 KiB 🟩 Total size was 1,823 KiB ↑ +0.1 %
Lighthouse JavaScript execution time 🟥 9.5 s 🟥 11.1 s ↑ +17.5 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +9.9 %
Lighthouse Minimizes main-thread work 🟥 19.0 s 🟥 19.9 s ↑ +4.9 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 710 ms 🟥 Potential savings of 1,120 ms ↑ +57.2 %
Lighthouse Initial server response time was short 🟩 Root document took 500 ms 🟩 Root document took 300 ms ↓ −40.7 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 72 KiB 🟥 Potential savings of 82 KiB ↑ +46.7 %
Lighthouse Max Potential First Input Delay 🟥 2,740 ms 🟥 2,830 ms ↑ +3.5 %
Lighthouse Server Backend Latencies 🟩 250 ms 🟩 160 ms ↓ −33.8 %
Lighthouse Network Round Trip Times 🟩 80 ms 🟩 20 ms ↓ −73.9 %
Lighthouse Largest Contentful Paint 🟨 3.0 s 🟨 3.0 s ↑ +0.3 %
Lighthouse Avoids an excessive DOM size 🟥 2,243 elements 🟥 2,245 elements ↑ +0.1 %
JS Packages Outdated NPM prod dependencies. 🟨 8 outdated package versions (5 major, 1 minor, 2 patch) 🟨 9 outdated package versions (5 major, 1 minor, 3 patch) ↑ +12.5 %
JS Packages Outdated NPM dev dependencies. 🟨 40 outdated package versions (26 major, 10 minor, 3 patch, 1 prerelease) 🟨 41 outdated package versions (26 major, 11 minor, 4 patch) ↑ +2.5 %

492 other audits are unchanged.

@github-actions github-actions bot removed the 🦾 CI/CD continuous integration and deployment label Nov 9, 2024
@BioPhoton BioPhoton marked this pull request as ready for review November 9, 2024 16:33
e2e/cli-e2e/tests/collect.e2e.test.ts Show resolved Hide resolved
static-environments/eslint-e2e-env/project.json Outdated Show resolved Hide resolved
static-environments/eslint-e2e-env/project.json Outdated Show resolved Hide resolved
matejchalk
matejchalk previously approved these changes Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants