Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): support GitLab report links #840

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

hanna-skryl
Copy link
Collaborator

Closes #722

This PR adds support for generating GitLab links in markdown reports when running in GitLab CI/CD, using predefined environment variables. It also refactors the environment detection logic to use a centralized environmentChecks record.

@hanna-skryl hanna-skryl self-assigned this Oct 14, 2024
Copy link

github-actions bot commented Oct 14, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit d902c2b with source commit c420a68.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 52 🔴 47 ↓ −5.2
Code coverage 🟢 90 🟢 90 ↑ +0.1
Custom checks 🟡 67 🟡 67
Security 🟡 82 🟡 82
Updates 🟡 77 🟡 77
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 6 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 52 🔴 47 ↓ −5.2
Code coverage Code coverage metrics 🟢 90 🟢 90 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.2 s 🟨 3.7 s ↑ +17.7 %
Lighthouse Speed Index 🟥 6.4 s 🟥 7.0 s ↑ +8.4 %
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.3 s ↑ +3.4 %
Lighthouse First Meaningful Paint 🟨 3.2 s 🟨 3.3 s ↑ +3.4 %
Lighthouse Time to Interactive 🟥 19.6 s 🟥 18.4 s ↓ −5.9 %
Code coverage Branch coverage 🟨 85.4 % 🟨 85.3 % ↓ −0.1 %
Code coverage Function coverage 🟩 92.4 % 🟩 92.5 % ↑ +0.1 %
Code coverage Line coverage 🟩 91.5 % 🟩 91.5 % ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 24.3 s 🟥 22.1 s ↓ −9.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.3 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,823 KiB 🟩 Total size was 1,821 KiB ↓ −0.1 %
Lighthouse Max Potential First Input Delay 🟥 4,900 ms 🟥 3,400 ms ↓ −30.6 %
Lighthouse Total Blocking Time 🟥 9,650 ms 🟥 8,280 ms ↓ −14.2 %
Lighthouse JavaScript execution time 🟥 11.8 s 🟥 10.5 s ↓ −10.6 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −5.9 %
Lighthouse Server Backend Latencies 🟩 150 ms 🟩 310 ms ↑ +101.4 %
Lighthouse Initial server response time was short 🟩 Root document took 410 ms 🟩 Root document took 530 ms ↑ +28.8 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,270 ms 🟥 Potential savings of 1,200 ms ↓ −6 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 60 ms ↑ +208.7 %
Lighthouse Avoids an excessive DOM size 🟥 2,250 elements 🟥 2,246 elements ↓ −0.2 %

493 other audits are unchanged.

@hanna-skryl hanna-skryl marked this pull request as ready for review October 14, 2024 20:34
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Left a small comment.

matejchalk
matejchalk previously approved these changes Oct 15, 2024
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dope

@hanna-skryl hanna-skryl merged commit f2744fd into main Oct 16, 2024
16 checks passed
@hanna-skryl hanna-skryl deleted the feat/gitlab-report-links branch October 16, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues sections should link to Git URL of file at given commit with highlighted line(s)
4 participants