-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make portal-client dependency optional #837
Merged
hanna-skryl
merged 2 commits into
main
from
feat/make-portal-client-dependency-optional
Oct 15, 2024
Merged
feat: make portal-client dependency optional #837
hanna-skryl
merged 2 commits into
main
from
feat/make-portal-client-dependency-optional
Oct 15, 2024
+67
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📖 Project documentation
improvements or additions to the project documentation
🧩 core
🧩 utils
🛠️ tooling
🧩 cli
labels
Oct 11, 2024
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit 01f02b6 with source commit c420a68. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👎 2 groups regressed, 👍 2 audits improved, 👎 6 audits regressed, 11 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
494 other audits are unchanged. |
hanna-skryl
force-pushed
the
feat/make-portal-client-dependency-optional
branch
from
October 11, 2024 23:46
0bdf575
to
bc325eb
Compare
hanna-skryl
force-pushed
the
feat/make-portal-client-dependency-optional
branch
from
October 12, 2024 00:39
bcdcf92
to
88b7fcd
Compare
BioPhoton
reviewed
Oct 12, 2024
matejchalk
reviewed
Oct 14, 2024
hanna-skryl
force-pushed
the
feat/make-portal-client-dependency-optional
branch
from
October 14, 2024 16:40
ebb2469
to
2971290
Compare
matejchalk
approved these changes
Oct 14, 2024
BioPhoton
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🧩 cli
🧩 core
📖 Project documentation
improvements or additions to the project documentation
🔬 testing
writing tests
🛠️ tooling
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #474
@code-pushup/portal-client
an optional peer dependency in the@code-pushup/core
package.@code-pushup/portal-client
.npm
,pnpm
, andyarn
setups.