Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor after core package intro #83

Merged
merged 8 commits into from
Oct 3, 2023
Merged

fix: refactor after core package intro #83

merged 8 commits into from
Oct 3, 2023

Conversation

BioPhoton
Copy link
Collaborator

No description provided.

@BioPhoton BioPhoton requested a review from matejchalk October 2, 2023 15:49
@BioPhoton BioPhoton mentioned this pull request Oct 2, 2023
Closed
matejchalk
matejchalk reviewed Oct 2, 2023
View reviewed changes
packages/cli/package.json Outdated Show resolved Hide resolved
packages/core/src/lib/collect-and-persist.ts Show resolved Hide resolved
packages/utils/src/index.ts Outdated Show resolved Hide resolved
@BioPhoton BioPhoton requested a review from matejchalk October 3, 2023 13:20
matejchalk
matejchalk approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement 👍

@BioPhoton BioPhoton merged commit aa39d09 into main Oct 3, 2023
@BioPhoton BioPhoton deleted the core-polish branch October 3, 2023 15:47
@BioPhoton BioPhoton mentioned this pull request Oct 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejchalk matejchalk matejchalk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BioPhoton @matejchalk