Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): handle invalid plugin filter options #828

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

hanna-skryl
Copy link
Collaborator

Closes #823

This PR improves error handling for --onlyPlugins and --skipPlugins, ensuring the command aborts when no valid plugins are provided to --onlyPlugins. Invalid plugins are ignored with warnings, and conflicts between the two options are handled with clear error messages.

@hanna-skryl hanna-skryl self-assigned this Sep 30, 2024
Copy link

github-actions bot commented Sep 30, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit ed078e1 with source commit cddbdd3.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 45 🟡 53 ↑ +7.4
Code coverage 🟡 90 🟡 90 ↓ −0.1
Custom checks 🟡 67 🟡 67
Security 🟡 87 🟡 87
Updates 🟡 78 🟡 78
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
👍 1 group improved, 👎 1 group regressed, 👍 7 audits improved, 👎 1 audit regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 45 🟡 53 ↑ +7.4
Code coverage Code coverage metrics 🟡 90 🟡 90 ↓ −0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse First Contentful Paint 🟥 3.5 s 🟨 2.7 s ↓ −23.1 %
Lighthouse First Meaningful Paint 🟨 3.5 s 🟨 2.7 s ↓ −20.9 %
Lighthouse Speed Index 🟥 6.6 s 🟨 5.7 s ↓ −13.2 %
Lighthouse Largest Contentful Paint 🟨 3.9 s 🟨 3.4 s ↓ −12.3 %
Lighthouse Time to Interactive 🟥 16.4 s 🟥 14.9 s ↓ −8.7 %
Code coverage Line coverage 🟩 91.9 % 🟩 91.4 % ↓ −0.5 %
Code coverage Branch coverage 🟨 85 % 🟨 85 % ↑ +0.1 %
Code coverage Function coverage 🟩 92.1 % 🟩 92.2 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,807 KiB 🟩 Total size was 1,795 KiB ↓ −0.6 %
Lighthouse Minimizes main-thread work 🟥 21.2 s 🟥 17.9 s ↓ −15.6 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.4 %
Lighthouse JavaScript execution time 🟥 9.9 s 🟥 8.3 s ↓ −15.8 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −8.7 %
Lighthouse Total Blocking Time 🟥 7,470 ms 🟥 6,140 ms ↓ −17.8 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,460 ms 🟥 Potential savings of 400 ms ↓ −72.7 %
Lighthouse Max Potential First Input Delay 🟥 3,060 ms 🟥 2,350 ms ↓ −23.4 %
Lighthouse Initial server response time was short 🟩 Root document took 460 ms 🟩 Root document took 550 ms ↑ +19.7 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 30 ms ↓ −49.5 %
Lighthouse Server Backend Latencies 🟩 120 ms 🟩 100 ms ↓ −15.7 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 71 KiB 🟥 Potential savings of 56 KiB ↑ +3.3 %
Lighthouse Avoids an excessive DOM size 🟥 2,243 elements 🟥 2,249 elements ↑ +0.3 %

492 other audits are unchanged.

@hanna-skryl hanna-skryl marked this pull request as ready for review September 30, 2024 22:37
matejchalk
matejchalk previously approved these changes Oct 1, 2024
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well described issue, BTW 👍

vmasek
vmasek previously approved these changes Oct 1, 2024
@hanna-skryl hanna-skryl dismissed stale reviews from vmasek and matejchalk via b499e77 October 1, 2024 20:40
@hanna-skryl hanna-skryl merged commit 9d75682 into main Oct 2, 2024
17 checks passed
@hanna-skryl hanna-skryl deleted the feat/invalid-plugin-filter-options branch October 2, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abort command execution on invalid onlyPlugin
3 participants