chore: synchronise prod dependencies with root #703
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing a merge of
package.json
dependencies, I found out that some of plugins' production dependencies are incorrectly categories or missing in our rootpackage.json
. This PR aims to amend that.Overview
There are 9 dependencies which are production dependencies somewhere but not mentioned in root.
Out of these 9, 3 are internal package dependencies (
@code-pushup/models
,@code-pushup/utils
,@code-pushup/core
)Rest should be synchronised:
nx
(dev dependency in root, prod vnx-plugin
)tslib
(missing in root, prod innx-plugin
)@nx/devkit
(dev dependency in root, prod innx-plugin
)eslint
(dev in root, prod inplugin-eslint
)lighthouse
(dev in root, prod inplugin-lighthouse
)lighthouse-logger
(missing in root, prod inplugin-lighthouse
)🆘 Please advise on how to resolve different versions in plugin vs root
package.json
I took max at the moment but not sure if that is the best strategy.