Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: synchronise prod dependencies with root #703

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Conversation

Tlacenka
Copy link
Collaborator

When implementing a merge of package.json dependencies, I found out that some of plugins' production dependencies are incorrectly categories or missing in our root package.json. This PR aims to amend that.

Overview

There are 9 dependencies which are production dependencies somewhere but not mentioned in root.
Out of these 9, 3 are internal package dependencies (@code-pushup/models, @code-pushup/utils, @code-pushup/core)

Rest should be synchronised:

  • nx (dev dependency in root, prod v nx-plugin )
  • tslib (missing in root, prod in nx-plugin)
  • @nx/devkit (dev dependency in root, prod in nx-plugin)
  • eslint (dev in root, prod in plugin-eslint)
  • lighthouse (dev in root, prod in plugin-lighthouse)
  • lighthouse-logger (missing in root, prod in plugin-lighthouse)

🆘 Please advise on how to resolve different versions in plugin vs root package.json I took max at the moment but not sure if that is the best strategy.

Copy link

github-actions bot commented Jun 12, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 994693d with source commit 4f1a8b0.

🏷️ Categories

🏷️ Category ⭐ Current score ⭐ Previous score 🔄 Score change
Updates 🟡 79 🟡 89 ↓ −10.1
Performance 🟡 77 🟡 70 ↑ +6.9
Security 🟢 100 🟢 94 ↑ +6.3
Accessibility 🟢 98 🟢 98
Best Practices 🟢 100 🟢 100
SEO 🟡 85 🟡 85
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
Code coverage 🟡 89 🟡 89
Custom checks 🟡 67 🟡 67

🗃️ Groups

👍 2 groups improved, 👎 1 group regressed
🔌 Plugin 🗃️ Group ⭐ Current score ⭐ Previous score 🔄 Score change
JS Packages NPM outdated dependencies 🟡 79 🟡 89 ↓ −10.1
Lighthouse Performance 🟡 77 🟡 70 ↑ +6.9
JS Packages NPM audit 🟢 100 🟢 94 ↑ +6.3

17 other groups are unchanged.

🛡️ Audits

👍 9 audits improved, 👎 3 audits regressed, 9 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Current value 📏 Previous value 🔄 Value change
Lighthouse Largest Contentful Paint element 🟩 1,620 ms 🟥 2,670 ms  −∞ %
JS Packages Vulnerabilities for NPM dev dependencies. 🟩 0 vulnerabilities 🟨 7 vulnerabilities (1 high, 6 moderate) ↓ −100 %
Lighthouse Max Potential First Input Delay 🟥 590 ms 🟥 310 ms ↑ +90 %
Lighthouse Cumulative Layout Shift 🟨 0.148 🟨 0.199  −∞ %
Lighthouse Largest Contentful Paint 🟩 1.6 s 🟨 2.7 s ↓ −39 %
JS Packages Outdated NPM prod dependencies. 🟨 12 outdated package versions (4 major, 3 minor, 5 patch) 🟩 8 outdated package versions (1 major, 3 minor, 4 patch) ↑ +50 %
Lighthouse First Contentful Paint 🟩 1.2 s 🟩 1.6 s ↓ −27 %
Lighthouse First Meaningful Paint 🟩 1.2 s 🟩 1.9 s ↓ −37 %
JS Packages Outdated NPM dev dependencies. 🟨 51 outdated package versions (23 major, 21 minor, 1 preminor, 5 patch, 1 prerelease) 🟨 56 outdated package versions (26 major, 23 minor, 1 preminor, 5 patch, 1 prerelease) ↓ −9 %
Lighthouse Time to Interactive 🟩 2.2 s 🟩 2.7 s ↓ −18 %
Lighthouse Total Blocking Time 🟥 660 ms 🟥 630 ms ↑ +5 %
Lighthouse Speed Index 🟩 1.6 s 🟩 2.2 s ↓ −25 %
Lighthouse Metrics 🟩 2225 🟩 2729 ↓ −18 %
Lighthouse Minimizes main-thread work 🟥 3.6 s 🟥 4.0 s ↓ −10 %
Lighthouse Server Backend Latencies 🟩 50 ms 🟩 20 ms ↑ +104 %
Lighthouse JavaScript execution time 🟩 0.0 s 🟩 0.0 s ↓ −40 %
Lighthouse Properly size images 🟥 Potential savings of 240 KiB 🟥 Potential savings of 240 KiB ↑ +7 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 0 ms ↑ +600 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 432 KiB 🟩 Total size was 432 KiB ↓ +0 %
Lighthouse Uses efficient cache policy on static assets 🟨 11 resources found 🟨 11 resources found ↓ +0 %
Lighthouse Initial server response time was short 🟩 Root document took 0 ms 🟩 Root document took 10 ms ↓ −50 %

488 other audits are unchanged.

packages/nx-plugin/package.json Outdated Show resolved Hide resolved
packages/plugin-eslint/package.json Outdated Show resolved Hide resolved
@Tlacenka Tlacenka requested a review from matejchalk June 12, 2024 17:06
@Tlacenka Tlacenka merged commit 0161e66 into main Jun 13, 2024
16 checks passed
@Tlacenka Tlacenka deleted the sync-dependencies branch June 13, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants