Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-eslint): handle rules which emit column 0 #522

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

matejchalk
Copy link
Collaborator

Fixed validation error coming from unicorn/no-abusive-eslint-disable rule - column 0 wasn't handled and failed validation.

CI error

image

Debugging

image

image

Copy link

nx-cloud bot commented Feb 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 30e6d33. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 9 targets

Sent with 💌 from NxCloud.

@matejchalk matejchalk added 🐛 bug something isn't working and removed 🔬 testing writing tests labels Feb 22, 2024
Copy link
Collaborator

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we don't highlight column range, this should be fine.

Side-note: The test examples are getting quite long 😓 would consider splitting.

@matejchalk matejchalk merged commit de791e1 into main Feb 23, 2024
20 checks passed
@matejchalk matejchalk deleted the handle-zero-columns-from-eslint branch February 23, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug something isn't working 🧩 eslint-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants