chore: remove ESLint issues from test files in core, plugin-eslint and utils #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tlacenka
requested review from
BioPhoton,
IKatsuba,
matejchalk and
MishaSeredenkoPushBased
Tlacenka
force-pushed
the
fix-eslint-in-test-files
branch
from
a00a337 to
19d42c3
Compare
matejchalk
previously approved these changes
Jan 10, 2024
Tlacenka
force-pushed
the
fix-eslint-in-test-files
branch
from
19d42c3 to
4d2f1ca
Compare
Tlacenka
force-pushed
the
fix-eslint-in-test-files
branch
from
4d2f1ca to
c0cb5ea
Compare
matejchalk
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the report and removed most ESLint related issues in test files and enabled rules where possible.
There are still ESLint issues in models (I will deal with those during my test refactor), nx-plugin (not relevant atm) and a few waiting for the rule to be enabled (so that I can disable the ESLint for that line)
Stats
Before: 189 errors, 364 warnings, 10 info
After: 183 errors, 271 warnings, 10 info
Link to report displayed in portal here.