Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(models): add default value for outputDir #358

Merged
merged 41 commits into from
Dec 18, 2023

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Dec 12, 2023

I tried to reduce the scope as much as possible. In addition I added comments in code and here to understand the changes better and have and easier review process. Hopefully this makes up the messy change.

This PR includes:

  • refine options
    • tests
    • separate functions for upload and persist
  • model changes
  • tests
  • refactored options, config and defaults
  • moved filename into defaults in config middle ware
    (formats follow in fix(cli): fix json format handling #360 )

Resources:
Overview of the target architecture can be found here: https://github.com/code-pushup/cli/wiki/Research:-Module-architecture-and-responsibilities

closes #321

@BioPhoton BioPhoton marked this pull request as ready for review December 12, 2023 12:35
@BioPhoton BioPhoton requested a review from Tlacenka December 14, 2023 13:02
@github-actions github-actions bot added 🦾 CI/CD continuous integration and deployment 🧩 nx-plugin labels Dec 15, 2023
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanations. The persist config handling now looks good 👍 But the same strategy cannot apply to the upload config, as described in comments.

e2e/cli-e2e/tests/print-config.e2e.test.ts Show resolved Hide resolved
packages/cli/src/lib/implementation/config-middleware.ts Outdated Show resolved Hide resolved
packages/core/src/lib/types.ts Outdated Show resolved Hide resolved
packages/core/src/lib/types.ts Outdated Show resolved Hide resolved
packages/core/src/lib/types.ts Outdated Show resolved Hide resolved
packages/models/src/lib/implementation/constants.ts Outdated Show resolved Hide resolved
packages/models/src/lib/implementation/constants.ts Outdated Show resolved Hide resolved
packages/core/src/lib/collect-and-persist.unit.test.ts Outdated Show resolved Hide resolved
packages/core/src/lib/upload.ts Outdated Show resolved Hide resolved
@BioPhoton BioPhoton requested a review from matejchalk December 17, 2023 22:00
packages/core/src/lib/upload.unit.test.ts Outdated Show resolved Hide resolved
packages/core/src/lib/upload.ts Outdated Show resolved Hide resolved
@BioPhoton BioPhoton requested a review from matejchalk December 18, 2023 14:11
@BioPhoton BioPhoton merged commit 5871f0e into main Dec 18, 2023
18 checks passed
@BioPhoton BioPhoton deleted the provide-default-for-outputDir branch December 18, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify a default location for outputDir
3 participants