Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ESLint audit's display value to "passed" instead of fallback to 0 #305

Closed
2 tasks done
matejchalk opened this issue Nov 22, 2023 · 0 comments · Fixed by #379 or #385
Closed
2 tasks done

Change ESLint audit's display value to "passed" instead of fallback to 0 #305

matejchalk opened this issue Nov 22, 2023 · 0 comments · Fixed by #379 or #385
Assignees
@matejchalk
Labels
➕ enhancement new feature or request 🧩 eslint-plugin
Milestone
2. Integration

Comments

@matejchalk
Copy link
Collaborator

matejchalk commented Nov 22, 2023 •
edited
Loading

Currently, audits from ESLint plugin provide a displayValue only when there are errors or warnings (e.g. 5 errors, 12 warnings, in rare cases 1 error, 21 warnings). When no displayValue is provided, we fallback to value, so for ESLint audits without errors we display 0. It would be better to display passed.

  • when there are no issues detected, set displayValue: 'passed'
  • update snapshots in tests with -u (0 ➡ passed)
@matejchalk matejchalk added this to the 2. Integration milestone Nov 22, 2023
@matejchalk matejchalk added the ➕ enhancement new feature or request label Nov 22, 2023
MishaSeredenkoPushBased added a commit that referenced this issue Dec 26, 2023
@MishaSeredenkoPushBased
chore(plugin-eslint): change eslint displayValue from 0 to passed
976dca1 
Closes #305

#305
Merged
MishaSeredenkoPushBased added a commit that referenced this issue Dec 26, 2023
@MishaSeredenkoPushBased
chore(plugin-eslint): change eslint displayValue from 0 to passed
db8f60e 
Closes #305

#305
@matejchalk matejchalk reopened this Jan 3, 2024
@matejchalk matejchalk mentioned this issue Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejchalk matejchalk

Labels
➕ enhancement new feature or request 🧩 eslint-plugin
Projects
None yet
Milestone
2. Integration
2 participants
@matejchalk @MishaSeredenkoPushBased