Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn the benchmarks in perf folders to TS and use ts-node script to execute them #154

Closed
BioPhoton opened this issue Oct 25, 2023 · 0 comments · Fixed by #253
Closed

Turn the benchmarks in perf folders to TS and use ts-node script to execute them #154

BioPhoton opened this issue Oct 25, 2023 · 0 comments · Fixed by #253
Assignees
@MishaSeredenkoPushBased
Labels
💡 good first issue good for newcomers 🧹 maintenance
Milestone
5. Enterprise

Comments

@BioPhoton
Copy link
Collaborator

BioPhoton commented Oct 25, 2023 •
edited by kristihoskova
Loading

#137
@BioPhoton BioPhoton added this to the 5. Enterprise milestone Oct 25, 2023
@BioPhoton BioPhoton added the 💡 good first issue good for newcomers label Oct 28, 2023
Merged
MishaSeredenkoPushBased added a commit that referenced this issue Nov 14, 2023
@MishaSeredenkoPushBased
chore(utils): move benchmarks to typescript, adjust types (#253)
58b0aec 
All benchmarks are now .ts, added types where necessary. 
Fixed some places in the benchmarked functions, where they returned not
proper values - it was the reason of the high scores of optimized1 and
optimized2 benchmarks 🙂
Used tsx for runtime, modified perf command, changed tsconfig.lib at
utils.
Closes #154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MishaSeredenkoPushBased MishaSeredenkoPushBased

Labels
💡 good first issue good for newcomers 🧹 maintenance
Projects
None yet
Milestone
5. Enterprise
Development

Successfully merging a pull request may close this issue.

chore(utils): move benchmarks to typescript, adjust types code-pushup/cli
2 participants
@BioPhoton @MishaSeredenkoPushBased