chore(plugin-eslint): fix ESLint issues in test files, enable node-pr…

…otocol rule
code-pushup · Jan 10, 2024 · a2ab7fb · a2ab7fb
1 parent 669d86a
commit a2ab7fb
Show file tree

Hide file tree

Showing 9 changed files with 20 additions and 22 deletions.
diff --git a/packages/plugin-eslint/.eslintrc.json b/packages/plugin-eslint/.eslintrc.json
@@ -10,10 +10,8 @@
     "@typescript-eslint/no-unsafe-return": "off", // 2 errors
     "functional/immutable-data": "off", // 2 errors
     "sonarjs/no-nested-template-literals": "off", // 1 error
-    "unicorn/better-regex": "off", // 1 warning
     "unicorn/explicit-length-check": "off", // 1 warning
     "unicorn/import-style": "off", // 5 warnings
-    "unicorn/prefer-node-protocol": "off", // 14 warnings
     "unicorn/prefer-top-level-await": "off" // 1 warning
   }
 }
diff --git a/packages/plugin-eslint/src/lib/eslint-plugin.integration.test.ts b/packages/plugin-eslint/src/lib/eslint-plugin.integration.test.ts
@@ -1,6 +1,6 @@
-import os from 'os';
-import { dirname, join } from 'path';
-import { fileURLToPath } from 'url';
+import os from 'node:os';
+import { dirname, join } from 'node:path';
+import { fileURLToPath } from 'node:url';
 import type { SpyInstance } from 'vitest';
 import type { Audit, PluginConfig, RunnerConfig } from '@code-pushup/models';
 import { toUnixPath } from '@code-pushup/utils';

diff --git a/packages/plugin-eslint/src/lib/eslint-plugin.ts b/packages/plugin-eslint/src/lib/eslint-plugin.ts
@@ -1,6 +1,6 @@
-import { mkdir, writeFile } from 'fs/promises';
-import { dirname, join } from 'path';
-import { fileURLToPath } from 'url';
+import { mkdir, writeFile } from 'node:fs/promises';
+import { dirname, join } from 'node:path';
+import { fileURLToPath } from 'node:url';
 import { PluginConfig } from '@code-pushup/models';
 import { name, version } from '../../package.json';
 import { ESLintPluginConfig, eslintPluginConfigSchema } from './config';

diff --git a/packages/plugin-eslint/src/lib/meta/hash.ts b/packages/plugin-eslint/src/lib/meta/hash.ts
@@ -1,4 +1,4 @@
-import { createHash } from 'crypto';
+import { createHash } from 'node:crypto';
 import { slugify } from '@code-pushup/utils';
 
 export function ruleIdToSlug(

diff --git a/packages/plugin-eslint/src/lib/meta/hash.unit.test.ts b/packages/plugin-eslint/src/lib/meta/hash.unit.test.ts
@@ -56,6 +56,6 @@ describe('jsonHash', () => {
   ])('should produce short hexadecimal hash for rule options: %j', options => {
     const hash = jsonHash(options);
     expect(hash).toHaveLength(16);
-    expect(hash).toMatch(/^[0-9a-f]+$/);
+    expect(hash).toMatch(/^[\da-f]+$/);
   });
 });
diff --git a/packages/plugin-eslint/src/lib/meta/rules.unit.test.ts b/packages/plugin-eslint/src/lib/meta/rules.unit.test.ts
@@ -1,6 +1,6 @@
 import { ESLint } from 'eslint';
-import { dirname, join } from 'path';
-import { fileURLToPath } from 'url';
+import { dirname, join } from 'node:path';
+import { fileURLToPath } from 'node:url';
 import type { SpyInstance } from 'vitest';
 import { RuleData, listRules, parseRuleId } from './rules';
 

diff --git a/packages/plugin-eslint/src/lib/nx.integration.test.ts b/packages/plugin-eslint/src/lib/nx.integration.test.ts
@@ -1,6 +1,6 @@
+import { dirname, join } from 'node:path';
+import { fileURLToPath } from 'node:url';
 import { setWorkspaceRoot } from 'nx/src/utils/workspace-root';
-import { dirname, join } from 'path';
-import { fileURLToPath } from 'url';
 import type { SpyInstance } from 'vitest';
 import { ESLintPluginConfig } from './config';
 import { eslintConfigFromNxProject, eslintConfigFromNxProjects } from './nx';

diff --git a/packages/plugin-eslint/src/lib/runner.integration.test.ts b/packages/plugin-eslint/src/lib/runner.integration.test.ts
@@ -1,9 +1,9 @@
 import { ESLint } from 'eslint';
-import { mkdir, rm, writeFile } from 'fs/promises';
-import os from 'os';
-import { dirname, join } from 'path';
-import { fileURLToPath } from 'url';
-import type { SpyInstance } from 'vitest';
+import { mkdir, rm, writeFile } from 'node:fs/promises';
+import os from 'node:os';
+import { dirname, join } from 'node:path';
+import { fileURLToPath } from 'node:url';
+import { SpyInstance, describe, expect, it } from 'vitest';
 import type { AuditOutput, Issue } from '@code-pushup/models';
 import { readJsonFile } from '@code-pushup/utils';
 import { listAuditsAndGroups } from './meta';

diff --git a/packages/plugin-eslint/src/lib/runner/index.ts b/packages/plugin-eslint/src/lib/runner/index.ts
@@ -1,6 +1,6 @@
-import { mkdir, writeFile } from 'fs/promises';
-import { platform } from 'os';
-import { dirname, join } from 'path';
+import { mkdir, writeFile } from 'node:fs/promises';
+import { platform } from 'node:os';
+import { dirname, join } from 'node:path';
 import type { Audit, AuditOutput, RunnerConfig } from '@code-pushup/models';
 import { pluginWorkDir, readJsonFile, toArray } from '@code-pushup/utils';
 import { lint } from './lint';