refactor: update commitlint and remove unnecessary changelog angular …

…dependency closes #776 Signed-off-by: Vojtech Masek <[email protected]>
code-pushup · Oct 18, 2024 · 5858cc8 · 5858cc8
1 parent 6244f3f
commit 5858cc8
Show file tree

Hide file tree

Showing 5 changed files with 6,159 additions and 5,932 deletions.
diff --git a/.github/labeler.yml b/.github/labeler.yml
@@ -76,5 +76,5 @@
           - 'esbuild.config.js'
           - '.github/ISSUE_TEMPLATE/**'
           - '.husky/**'
-          - 'commitlint.config.js'
+          - 'commitlint.config.mjs'
           - '.verdaccio/config.yml'
diff --git a/commitlint.config.js → commitlint.config.mjs b/commitlint.config.js → commitlint.config.mjs
@@ -1,25 +1,23 @@
-const { RuleConfigSeverity } = require('@commitlint/types');
-const { rules } = require('@commitlint/config-conventional');
-const {
-  utils: { getProjects },
-} = require('@commitlint/config-nx-scopes');
+import config from '@commitlint/config-conventional';
+import nxScopes from '@commitlint/config-nx-scopes';
+import { RuleConfigSeverity } from '@commitlint/types';
 
 /** @type {import('@commitlint/types').UserConfig} */
-const configuration = {
+export default {
   extends: ['@commitlint/config-conventional'],
   plugins: ['commitlint-plugin-tense'],
   rules: {
     'scope-enum': async ctx => {
-      const projects = await getProjects(
+      const projects = nxScopes.utils.getProjects(
         ctx,
-        ({ name, projectType, tags }) =>
+        ({ projectType }) =>
           projectType === 'library' || projectType === 'application',
       );
       const scopes = [...projects, 'tools', 'workflows', 'testing'].sort();
       return [RuleConfigSeverity.Error, 'always', scopes];
     },
     'type-enum': () => {
-      const defaultTypes = rules['type-enum'][2];
+      const defaultTypes = config.rules['type-enum'][2];
       const types = [
         ...defaultTypes,
         'release', // custom type for release commits
@@ -33,5 +31,3 @@ const configuration = {
     ],
   },
 };
-
-module.exports = configuration;
diff --git a/knip.config.ts b/knip.config.ts
@@ -1,5 +1,5 @@
 import {
-  KnipConfigPlugin,
+  type KnipConfigPlugin,
   combineNxKnipPlugins,
   withEsbuildApps,
   withEsbuildPublishableLibs,
@@ -48,7 +48,7 @@ const withNxStandards = (): KnipConfigPlugin => () => {
     project: ['**/*.{ts,js,tsx,jsx}'],
     ignore: ['tmp/**', 'node_modules/**'],
     commitlint: {
-      config: ['commitlint.config.js'],
+      config: ['commitlint.config.mjs'],
     },
     exclude: ['duplicates'],
     entry: [