fix(plugin-eslint): startLine 0 should not create a position object

code-pushup · Mar 18, 2024 · 2db0d1d · 2db0d1d
1 parent 525b059
commit 2db0d1d
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 12 deletions.
diff --git a/packages/models/src/lib/issue.ts b/packages/models/src/lib/issue.ts
@@ -8,7 +8,7 @@ const sourceFileLocationSchema = z.object(
     position: z
       .object(
         {
-          startLine: positiveIntSchema.describe('Start line').optional(),
+          startLine: positiveIntSchema.describe('Start line'),
           startColumn: positiveIntSchema.describe('Start column').optional(),
           endLine: positiveIntSchema.describe('End line').optional(),
           endColumn: positiveIntSchema.describe('End column').optional(),

diff --git a/packages/plugin-eslint/src/lib/runner/transform.ts b/packages/plugin-eslint/src/lib/runner/transform.ts
@@ -65,16 +65,18 @@ function convertIssue(issue: LintIssue): Issue {
     severity: convertSeverity(issue.severity),
     source: {
       file: issue.filePath,
-      position: {
-        ...(issue.line > 0 && { startLine: issue.line }),
-        ...(issue.column > 0 && { startColumn: issue.column }),
-        ...(issue.endLine &&
-          issue.endLine > 0 && {
-            endLine: issue.endLine,
-          }),
-        ...(issue.endColumn &&
-          issue.endColumn > 0 && { endColumn: issue.endColumn }),
-      },
+      ...(issue.line > 0 && {
+        position: {
+          startLine: issue.line,
+          ...(issue.column > 0 && { startColumn: issue.column }),
+          ...(issue.endLine &&
+            issue.endLine > 0 && {
+              endLine: issue.endLine,
+            }),
+          ...(issue.endColumn &&
+            issue.endColumn > 0 && { endColumn: issue.endColumn }),
+        },
+      }),
     },
   };
 }

diff --git a/packages/plugin-eslint/src/lib/runner/transform.unit.test.ts b/packages/plugin-eslint/src/lib/runner/transform.unit.test.ts
@@ -251,7 +251,6 @@ describe('lintResultsToAudits', () => {
               severity: 'warning',
               source: {
                 file: 'src/app/test/strictNullChecks.ts',
-                position: { startColumn: 1 },
               },
             },
           ],