-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the table for the popcorn demo #69
base: master
Are you sure you want to change the base?
Conversation
@Tigul please add the board, where the pot spawns, and its symmetric counterpart, both under the drawers. Also, is it really necessary to delete the "wall7"? In the real lab the wall is there, is it maybe located at a different pose? In that case it's better to fix the pose of the wall instead of deleting it. |
@Tigul I'll keep this PR open until Thomas is done with his demo, I guess. Then we can merge the complete version of the table and won't need any follow-up PRs. |
|
||
<!-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tigul why did you delete kitchen_wall_7?
@Tigul @tlipps the popcorn table shouldn't be per default added to the kitchen URDF. It should rather be optional. It definitely shouldn't be added to the kitchen URDF like this. So either there should be a new combined URDF, which pull in both the ktichen and the popcorn table, or on the CRAM side we should be able to handle multiple environment objects, like |
</iai_kitchen_wall_robohow> | ||
|
||
|
||
<iai_popcorn_table name="iai_popcorn_table" parent="room_link"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weg.
@Tigul please give |
Added
Pictures
New top level file
A new top level file was added which combines all macros. This creates a kitchen with the popcorn table and without the wall_7.
New parameter in IAI_kitchen_walls
For the purpose of creating a kitchen without the wall_7 a new parameter was added to the macro. This parameter, named "wall_7", is a boolean value that is set to true if the wall should be included and false if not.