Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Long- Rather than Short-Form Commit Hash #33

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Hamms
Copy link

@Hamms Hamms commented Sep 7, 2023

Otherwise, we get the following error when trying to install this dependency with Yarn > 1.x:

➤ YN0001: │ Error: eshost@github:pcardune/eshost#f3fa7fa: Invalid commit hash

In the long run, it would be ideal to get these dependencies back on mainline, but as a short-term fix this should be quite safe.

Testing Story

Verified with "@code-dot-org/js-interpreter-tyrant": "code-dot-org/js-interpreter-tyrant#use-valid-commit-hash", that with this change, we can successfully install this dependency in our main repo using Yarn 3.6.3

Deployment Strategy

After approval and merge, I will run the following commands to publish a new 0.2.3 version which our main repo can target in order to support Yarn > 1.x:

npm version patch
git push
git push --tags
npm publish

Otherwise, we get the following error when trying to install this dependency with Yarn > 1.x:

    ➤ YN0001: │ Error: eshost@github:pcardune/eshost#f3fa7fa: Invalid commit hash
@Hamms Hamms marked this pull request as ready for review September 7, 2023 20:47
@Hamms Hamms requested a review from a team September 7, 2023 20:52
@Hamms Hamms added the dependencies Pull requests that update a dependency file label Sep 7, 2023
@Hamms Hamms marked this pull request as draft September 7, 2023 21:37
Copy link

@cat5inthecradle cat5inthecradle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is this still a draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants