Hint paths #18470
Merged
Hint paths #18470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
reviewed
Oct 18, 2017
| )} | ||
| {!this.props.collapsed && this.props.hints && this.props.hints.map((hint) => { | ||
| if (hint.hintPath) { | ||
| window.dispatchEvent(new CustomEvent('displayHintPath', {detail: hint.hintPath})); |
There was a problem hiding this comment.
I'm really not a fan of a map operation having a side effect. Can the craft app not subscribe to the redux store directly?
There was a problem hiding this comment.
The problem is that Redux really wants you to subscribe via connect. See: reduxjs/redux#580 (comment).
I can do store.subscribe() to get notified on every single Redux action, then look at store.getState().authoredHints.seenHints to see if a hint is visible that doesn't match a cached list. Do you prefer that approach?
|
@Hamms PTAL! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample usage: