Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add price to Subscription #609

Merged
merged 5 commits into from
Jun 15, 2020
Merged

Conversation

ianko
Copy link
Contributor

@ianko ianko commented Jun 10, 2020

Subscriptions can have either plan or price attributes. Because of that, the documentation states that the plan parameter is optional when creating or updating subscriptions.

I missed to modify this module when created the Price module on my previous PR (#603).

ianko and others added 4 commits May 29, 2020 22:28
Update various stripe objects with missing fields, remove deprecated …
…to feature/price

# Conflicts:
#	lib/stripe/subscriptions/subscription.ex
@coveralls
Copy link

coveralls commented Jun 10, 2020

Coverage Status

Coverage remained the same at 89.855% when pulling 1c8688b on fanhero:feature/price into 337807d on code-corps:master.

@snewcomer
Copy link
Collaborator

Thank you for this! Looks like a minor formatting issue somewhere

Screen Shot 2020-06-12 at 8 14 09 AM

@ianko
Copy link
Contributor Author

ianko commented Jun 12, 2020

Oops... Fixed.

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you thank you!!

@snewcomer snewcomer merged commit bcb2307 into beam-community:master Jun 15, 2020
jalexander pushed a commit to Frameio/stripity_stripe that referenced this pull request Nov 20, 2024
* add price to subscriptions

* add price to subscriptions

* run format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants