Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Price core resource #603

Closed
wants to merge 2 commits into from

Conversation

ianko
Copy link
Contributor

@ianko ianko commented May 20, 2020

Stripe has a new, and recommended, way to deal with prices for both recurring and one-time purchases of products.

API doc: https://stripe.com/docs/api/prices
Guide: https://stripe.com/docs/billing/prices-guide
Migration Guide: https://stripe.com/docs/billing/migration/migrating-prices

@coveralls
Copy link

coveralls commented May 20, 2020

Coverage Status

Coverage increased (+0.1%) to 88.211% when pulling 1eead04 on fanhero:feature/core_price into 0d419bf on code-corps:master.

to include the prices endpoit
@ianko
Copy link
Contributor Author

ianko commented May 20, 2020

Don't know what is going on with the tests, since it's failing on entities that I didn't touch.

I was probably fixed by the PR #602. I've also submitted a PR to the author with this same exact changes.

@ianko
Copy link
Contributor Author

ianko commented May 27, 2020

Since the #602 was merged, and it included the same work done here, I am closing this one.

Thank you.

@ianko ianko closed this May 27, 2020
@snewcomer
Copy link
Collaborator

Thank you @ianko!

@ianko ianko deleted the feature/core_price branch June 1, 2020 20:10
@ianko ianko mentioned this pull request Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants