Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functions.js channel not initialized on international YT #2444

Merged
merged 1 commit into from
Jul 4, 2024
Merged

functions.js channel not initialized on international YT #2444

merged 1 commit into from
Jul 4, 2024

Conversation

raszpl
Copy link
Contributor

@raszpl raszpl commented Jul 4, 2024

Switched language and 'ytd-c4-tabbed-header-renderer' became 'yt-subscribe-button-view-model-wiz' somehow

Switched language and 'ytd-c4-tabbed-header-renderer' became 'yt-subscribe-button-view-model-wiz' somehow
@ImprovedTube ImprovedTube merged commit a30c959 into code-charity:master Jul 4, 2024
1 check failed
@ImprovedTube
Copy link
Member

hi! @raszpl thanks, are we including yt-subscribe-button-view-model-wiz then?

we can hoard all DOM names.
(and eventually one could collect statistics how common they are or not)


Happy / proud to tell BTW, that everything merged is live once again! At https://chromewebstore.google.com/detail/improve-youtube-%F0%9F%8E%A7-for-yo/bnomihfieiccainjcjblhegjgglakjdd, while uninstalls / reinstalls aren't raised

@raszpl
Copy link
Contributor Author

raszpl commented Jul 4, 2024

hi! @raszpl thanks, are we including yt-subscribe-button-view-model-wiz then?

thankfully it happened on

<yt-subscribe-button-view-model class="yt-subscribe-button-view-model-wiz" style="width: 172px;">

so no need

Happy / proud to tell BTW, that everything merged is live once again! At https://chromewebstore.google.com/detail/improve-youtube-%F0%9F%8E%A7-for-yo/bnomihfieiccainjcjblhegjgglakjdd,

👍

while [uninstalls / reinstalls]

people probably havent woken up yet :]

(https://improvedtube.com/uninstalls-hours-days-usatime-updated-every-3-minutes) aren't raised

a ton of those from 1-2 weeks ago was probably mine until I removed last line from background.js in my local debug copy :P

@raszpl raszpl deleted the patch-5 branch July 4, 2024 06:07
@ImprovedTube
Copy link
Member

ImprovedTube commented Jul 4, 2024

hi @raszpl

a ton of those from 1-2 weeks ago was probably mine until I removed last line from background.js in my local debug copy :P

how? 1000 is little since we are featured at firefox about:addons ( #2411 )

people probably havent woken up yet :]

According to discord: finer speed increments? (And adblock-warning with adblocking enabled)

@raszpl
Copy link
Contributor Author

raszpl commented Jul 4, 2024

a ton of those from 1-2 weeks ago was probably mine until I removed last line from background.js in my local debug copy :P

how?

I had to install/uninstall fo debugging and was triggering the report, got annoyed after few days and removed it from local copy

@ImprovedTube
Copy link
Member

💡now i remembered whats the last line!
reloading should be enough.

@raszpl
Copy link
Contributor Author

raszpl commented Jul 5, 2024

💡now i remembered whats the last line! reloading should be enough.

not when one is testing "onInstalled" code while lazy :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants