Update core.js blocklist: safety, properly initialize, speed #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raszpl
changed the title
…g commented stuff to more logical place
separate functions for node/channel/initialization
…rom source thumbnail
ImprovedTube
added
the
Open!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tons of checks, everything is checked and initialized properly, switched to separate dedicate functions as its slightly faster.
Blocklist icon popups should be showing on video-previews now. Its not ideal, blocked thumbnails glitch a little when hovering over in search, needs some more CSS love.
#2236
#2334
#2393
also adds new
ImprovedTube.createIconButton()function in \js&css\web-accessible\functions.js Extension has ~7 icon buttons used https://github.com/search?q=repo%3Acode-charity%2Fyoutube%20http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg&type=code and they are being manually created with icons stored all over the codebase, now all icons should be moved to centralImprovedTube.button_icons = {}repository in \js&css\web-accessible\core.js