Update player.js playerQualityWithoutFocus breaks on switching tabs

[raszpl]

youtube/background.js

Lines 179 to 202 in d806571

	chrome.windows.onFocusChanged.addListener(function (windowId) {
	chrome.windows.getAll(function (windows) {
	for (var i = 0, l = windows.length; i < l; i++) {
	if (windows[i].focused === true) {
	chrome.tabs.query({
	windowId: windows[i].id
	}, function (tabs) {
	if (tabs) {
	for (var j = 0, k = tabs.length; j < k; j++) {
	var tab = tabs[j];
	if (tab.active) {
	chrome.tabs.sendMessage(tab.id, {action: 'focus'});
	}
	}
	}
	});
	} else {
	chrome.tabs.query({windowId: windows[i].id}, function (tabs) {
	if (tabs) {
	for (var j = 0, k = tabs.length; j < k; j++) {
	var tab = tabs[j];
	chrome.tabs.sendMessage(tab.id, {action: 'blur'});

sends additional second blur message on tab switch

this

youtube/js&css/web-accessible/www.youtube.com/player.js

Line 411 in d806571

ImprovedTube.qualityBeforeBlur = player.getPlaybackQuality();

sets qualityBeforeBlur again when already minimized, this time to this.storage.player_quality_without_focus. After rocusing back video quality is "restored" to qualityBeforeBlur === this.storage.player_quality_without_focus.

background.js is sending second blur event. Its sending multiple ones when whole browser is minimized for example, or tab switched. Dont know why and if its needed. Definitely sending events to tabs where extension is not running is not good.

[ImprovedTube]

hi @rasz_pl

could also use tab.id 😁

youtube/background.js

Line 162 in 6538d6a

# TAB FOCUS/BLUR

---

and to undo if the low quality makes it to a new session...? :

if (ImprovedTube.qualityBeforeBlur) { ... } 
else { if ( qualityWithoutFocus === player.getPlaybackQuality() ) {ImprovedTube.playerQuality(ImprovedTube.player_quality || undefined); } ) 

[raszpl]

hi @rasz_pl

could also use tab.id 😁

should. I dont know why background.js is doing what its doing, but whatever its doing its doing too much of it
to elaborate: why is this code in background.js to begin with? all this mess(double messages, messaging all the tabs) can be replaced by sticking

window.addEventListener("blur", (event) => {
});
window.addEventListener("focus", (event) => {
});

somewhere around here

youtube/js&css/web-accessible/init.js

Line 134 in 8223c7d

document.addEventListener('yt-page-data-updated', function (event) {

[ImprovedTube]

hi! @raszpl

idk, previously assumed manifest3 broke it: #1516 (comment)

brings us back here: #1439 and #bugs+#important

version 3.965.zip ( = view repo at october7 2022 )

At least we should still look at 3.965 to fetch the features not migrated to 4.0 (Mixer, Analyzer & Custom CSS & JS)
(and there might be more good code missing since 4.0)

( obvious change in 4.0 stuff was moving stuff from web-accessible youtube-scripts.js to content scripts:

	"content-scripts/extension-context/youtube-features/night-mode/night-mode.js",
	"content-scripts/extension-context/youtube-features/general/general.js",
	"content-scripts/extension-context/youtube-features/appearance/player/player.js",
	"content-scripts/extension-context/youtube-features/appearance/details/details.js",
	"content-scripts/extension-context/youtube-features/appearance/sidebar/sidebar.js",
	"content-scripts/extension-context/youtube-features/appearance/comments/comments.js",					

And there was the plan to allow HTMLmediaelement features on all sites. Or integrate/invite https://github.com/xxxily/h5player / & https://greasyfork.org/en/scripts/30545. ( And care for top URLs like m.youtube & facebook.com/watch) (So that must be why the sub-folders were called "youtube" for 4.0 )