Special 'satus_remove' value signaling default option, remove instead of storing

[raszpl]

Special 'satus_remove' value signaling default option. Storing 'satus_remove' in any config variable automagically deletes it. For example User switching player_quality back to auto will set it to 'satus_remove' value which in turn will automatically delete player_quality key from config.

Converted components.switch to only store active usage, flipping switch to default position deletes it from config. This respects skeleton.value: true witches that start as default ON like up_next_autoplay. Those only save False value and get automatically deleted when switched to True.

In principle no additional code changes should be required to \web-accessible\ side of extension, but this opens possibility of simplifying code a lot. After automatically converting all user configs on next upgrade we will no longer have to check for config_variable != 'disabled', != 'auto',=== true, === false, this.isset(option) etc.

[ImprovedTube]

wow! 🥰

[ImprovedTube]

😏

[raszpl]

Tested, working. Could be merged right now after adding code converting user configs (deleting all redundant true/false settings).

.

[ImprovedTube]

we currently have: (old news:)
3 defaults at installation (extra buttons below the player. Thanks for caring at #2085),

• (which always appeared inverted in "my active features", in favor of the inverted ones😲. Yet should even appear as "my active features(3)" on the front screen . as a workaround currently they could have the skeleton value false and be enabled at installation in background.js )

and
7+ inverted switches just representing youtube's defaults covered by 36131ca ( d18cea6 3342afc 1253b9e),
( which are also "trashbin/cleaning" features (like many of our toggles and dropdown options called hidden, disabled, block). ( #1685 "long term structure" )

• could alternatively only have an inverted switch/light by default visually only/CSS, just indicate YouTube's default and that it might be nice/performant to get rid of these. so using another toggle type in the skeleton "inverted=true". (and can be called negated NOhdr or hdrOFF in the code, like you started)

[ImprovedTube]

( satus_remove ~= default? besides

youtube/menu/styles/sub-options.css

Line 30 in f6b84f3

#subtitles-language[data-value='default'] + .satus-switch,

youtube/js&css/extension/www.youtube.com/styles.css

Line 652 in f6b84f3

html[it-theme]:not([it-theme=default]):not([it-theme=dark]) .yt-core-attributed-string__link--call-to-action-color {color: var(--yt-spec-call-to-action)}

)

[ImprovedTube]

youtube/js&css/web-accessible/core.js

Lines 234 to 235 in f6b84f3

	} else if (ImprovedTube.storage.transcript === false) {
	document.querySelector('*[target-id*=transcript] #visibility-button button')?.click();

(as of 6b56ee0:
satus.storage.remove(key);
parent.dispatchEvent(new CustomEvent('change'));

---

then need to search & replace ...storage.... === false 💭 /if\s*\(([^\)]*storage[^\)]*)\s*(=+\s*false|\!=+\s*true)\s*)\s*{/if (\!$1)/ (except for the true's by default: /if\s*\(([^\)]*storage[^\)]*)\s*(=+\s*true|\!=+\s*false)\s*)\s*{/if (\$1)/ )

[raszpl]

( satus_remove ~= default?

yes but mostly no :) satus_remove makes the selection delete itself, so it works like user never touched that option in the first place.

youtube/menu/styles/sub-options.css

Line 30 in f6b84f3

#subtitles-language[data-value='default'] + .satus-switch,

1 ha! I was wondering why this code

youtube/menu/satus.js

Line 1625 in f6b84f3

this.dataset.value = this.value;

now I know

2 hmm #subtitles-language is never created

youtube/menu/skeleton-parts/player.js

Lines 160 to 163 in f6b84f3

	subtitles_language: {
	component: 'select',
	text: 'language',
	id: 'language_closed_caption',

we create #language_closed_caption instead, looks like this entry is corrupted? its text references "language" while it should be "language_closed_caption"?
https://github.com/search?q=repo%3Acode-charity%2Fyoutube+language_closed_caption+language%3AJSON&type=code&l=JSON

so this never worked to begin with :o
probably should be

text: 'language_closed_caption', 
id: 'subtitles-language'

or CSS rule modified to reference #language_closed_caption

youtube/js&css/extension/www.youtube.com/styles.css

Line 652 in f6b84f3

html[it-theme]:not([it-theme=default]):not([it-theme=dark]) .yt-core-attributed-string__link--call-to-action-color {color: var(--yt-spec-call-to-action)}

not gonna be a problem. User setting theme back to default will remove satus.storage.data.theme / ImprovedTube.storage.theme

youtube/js&css/web-accessible/core.js

Lines 234 to 235 in f6b84f3

	} else if (ImprovedTube.storage.transcript === false) {
	document.querySelector('*[target-id*=transcript] #visibility-button button')?.click();

💭need to search & replace ...storage.... === false

when extension is first installed(or all settings reset) ImprovedTube.storage.transcript doesnt exist at all, so this is bad code? it will only work if User first flips transcript ON then OFF. It was always broken :(

Another similar, but borderline working example is

youtube/js&css/web-accessible/www.youtube.com/player.js

Lines 642 to 656 in f6b84f3

	if (ImprovedTube.storage.player_screenshot_save_as !== 'clipboard') {
	var a = document.createElement('a');
	a.href = URL.createObjectURL(blob); console.log("screeeeeeenshot tada!");
	a.download = (ImprovedTube.videoId() || location.href.match) + ' ' + new Date(ImprovedTube.elements.player.getCurrentTime() * 1000).toISOString().substr(11, 8).replace(/:/g, '-') + ' ' + ImprovedTube.videoTitle() + (subText ? ' - ' + subText.trim() : '') + '.png';
	a.click();
	} else {
	navigator.clipboard.write([
	new ClipboardItem({
	'image/png': blob
	})
	]);
	}

it checks for ImprovedTube.storage.player_screenshot_save_as !== 'clipboard', and when you install extension

youtube/menu/skeleton-parts/player.js

Lines 1020 to 1029 in f6b84f3

	player_screenshot_save_as: {
	component: 'select',
	text: 'saveAs',
	options: [{
	text: 'file',
	value: 'file'
	}, {
	text: 'clipboard',
	value: 'clipboard'
	}]

its neither clipboard nor file so it works by shear luck/someone using reverse reverse logic :)
4abaeeb flips that around to straightforward check for == 'clipboard', otherwise perform default action (file)

[ImprovedTube]

sorry, edit: #2220 (comment)

it will only work if User first flips.

yes, in the section (most of core.js) is for demonstrating the effect of features immediately.
and undoing them immediately too.

youtube/js&css/web-accessible/core.js

Line 176 in f6b84f3

// REACTION OR VISUAL FEEDBACK WHEN THE USER CHANGES A SETTING (already automated for our CSS features):

Checking === false 17 times yet.

( one default true

youtube/js&css/web-accessible/core.js

Lines 190 to 191 in f6b84f3

	if (ImprovedTube.storage.player_60fps === false) {
	localStorage['it-player30fps'] = true;

)

---

while others could be shortened by regex

youtube/js&css/web-accessible/www.youtube.com/shortcuts.js

Line 684 in 427b3ed

if (ImprovedTube.storage.below_player_loop !== false) {

youtube/js&css/web-accessible/www.youtube.com/appearance.js

Line 334 in 427b3ed

if (this.storage.below_player_loop !== false) {

---

Aaand one default:true-toggle's default actually ultimately depends country
(some have the 12-hour format when written ISO 3166-1: ae,af,al,am,bd,bh,bt,co,cr,dj,do,dz,eg,eh,er,et,gh,gm,gt,hn,iq,jo,kh,kp,kw,lb,lr,ly,ma,mm,mo,mr,my,na,ni,np,om,pa,ph,pr,ps,qa,sa,sd,sl,so,ss,sv,sy,td,tn,to,us,ve,vu,xs,xz,ye)

youtube/menu/skeleton-parts/analyzer.js

Line 30 in 427b3ed

if (satus.storage.get('use_24_hour_format') === false) {

youtube/menu/skeleton-parts/night-mode.js

Line 61 in 427b3ed

return satus.storage.get('use_24_hour_format') === false;

youtube/menu/skeleton-parts/night-mode.js

Line 69 in 427b3ed

return satus.storage.get('use_24_hour_format') === false;

---

and to be complete /mentioned before: a few Features / "Experiment Flags" might also meaningfully be stored on both sides, disable or enable - if youtube doesnt have a default like currently for comments on the side (disable Youtube's?; enable Youtube's?; our Version?). Still we don't need to store any "false" values or 3x bool, deleted when a competing one is enabled.

[raszpl]

I dont think you can regex all changes, there are logical traps like !== 'clipboard'.

Anyway after good sleep I had an epiphany - Im going at it all wrong :). Magic 'satus_remove' value approach was wrong direction, we already have all what needed in current menu/*.js files as is, no need for additional magic values.

Ill start again, third times a charm as they say.

[raszpl]

Ill start again, third times a charm as they say.

done #2262 . No more magic values, No more data markers. Every Satus function detects default value automatically and acts accordingly.