Add option to automatically disable captions in lyrics/karaoke videos #1235

[ThomSipkens]

I've added an option that toggles captions when a Lyrics/karaoke video is detected. This fixes #1235 . Should note, that with most music videos, the captions get automatically disabled anyways, but this is extra for whenever it has not been configured.

[ImprovedTube]

welcome and thanks! @ThomSipkens

player.toggleSubtitles();

will it have an effect on following videos?

alternative: we can move the titles out of view (or hide them)

youtube/js&css/web-accessible/www.youtube.com/player.js

Line 626 in c0b1679

var captionElements = document.querySelectorAll('.captions-text .ytp-caption-segment');

[ThomSipkens]

Hey, that is a very good point about the effect on following videos. The feature is designed with the idea of having the captions enabled through the extension, making any effect of this feature undone after the video ends. Considering the users are already using the captions in the extension to begin with, I would assume that mostly there should be no problem. However, there can be a small use-case where the captions were turned on manually, the extension has captions not enabled and the disable caption for lyrics is enabled. One way to fix this, could be to make the new feature only applicable when captions are also enabled. Another option is to find a way to undo the effects anyway, regardless of any setting.