satus.js formatting, fixing some variable declarations

[raszpl]

nothing important, just fixing some errors/warnings thrown by linter

[Tithi49]

Thank you for your email

…

On Mon, 25 Mar, 2024, 11:15 AM Rasz_pl, ***@***.***> wrote: ------------------------------ You can view, comment on, or merge this pull request online at: #2122 Commit Summary - 430d410 <430d410> satus.js formatting, fixing some variable declarations File Changes (1 file <https://github.com/code-charity/youtube/pull/2122/files>) - *M* menu/satus.js <https://github.com/code-charity/youtube/pull/2122/files#diff-aa070d70668ef5ddb7074b927650ba09e8657c8ed2e5524cd8841f171174e786> (268) Patch Links: - https://github.com/code-charity/youtube/pull/2122.patch - https://github.com/code-charity/youtube/pull/2122.diff — Reply to this email directly, view it on GitHub <#2122>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A45NS7ZLOKIXN2I6FEK4DITYZ62XJAVCNFSM6AAAAABFGMSPN2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYDIOJVGMYDEMA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[ImprovedTube]

revert: 033ed4d
( @raszpl )

[raszpl]

doh! 'self' is declared one line above and is only used in that one line below

		var self = this,
			parent = parent || self.primary,
			children = parent.children;

weird code, someone declared 'self' to just use it once one line over :|. 'this' should be used directly #2146 :

	component.render = function(parent = this.primary) {
		let children = parent.children;

btw when testing shortucuts I noticed:

.satus-modal__surface {
    color: var(--satus-modal-foreground);

sets text color same as foreground, makes shortcuts white text on white rectangle in most themes. Should be same as:

.satus-shortcut__value>.satus-shortcut__key {
    color: var(--satus-shortcut-key-text);

it actually looks like maybe at some point this rule covered it, but now keys in popup are under .satus-shortcut__primary>.satus-shortcut__key
fix #2145