Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments: Sidebar update #1697

Merged
merged 9 commits into from
Jul 4, 2023
Merged

Comments: Sidebar update #1697

merged 9 commits into from
Jul 4, 2023

Conversation

D-Rekk
Copy link
Contributor

@D-Rekk D-Rekk commented Jun 7, 2023

Implementing idea from #1664.

Preview

May-27-2023 12-49-11

Features:

  • Layout is dynamic and responsive
  • Sidebars are attached and scrollable
  • Added grid composition to related videos
  • player width is correctly set through JS (temporary)

What's missing yet?

  • Option relocation and renaming convention. This option is currently located in Appearance -> Comments solely as "Sidebar". Instead, it should be placed in Appearance -> Sidebar under the name of "Swap Sidebar with Comments"
  • Many styles should be extracted in their own setting options, such as:
    • "Comments as Sidebar" (currently available only on width 1984px+. Zoom at 80% to try)
    • "Comments Sidebar - To the left"

What's not working with Comments -> Sidebar activated?

  • Any Player -> Player Size other than "normal"
  • Sidebar -> To The Side! which should get removed in favor of a grid option
  • Other visibility settings in Appearance that affect Sidebar and Comments

@ImprovedTube
Copy link
Member

ImprovedTube commented Jun 12, 2023

exciting!

  • the related videos grid works well & can be a good feature alone too (can then start below 1920)
    • grid doesnt seem to take effect when logged-out of youtube (?)
  • ( scrollbars will also make another feature alone, without comments in sidebar) )

  • chrome & windows10 gives me the empty/not functioning scrollbars
  • we could release it immediately keeping the old feature, and the new one as comments : "sidebar+" - or could rename the old feature comments > sidebar-simple and migrating the setting there (through background.js) considering setups where the new one isnt yet supported

- Copied styles from master branch + some changes
- Removed "comment" from styleScrollbars func
@ImprovedTube ImprovedTube mentioned this pull request Jun 13, 2023
@D-Rekk
Copy link
Contributor Author

D-Rekk commented Jun 14, 2023

Should be all set!

  • Script updated to fix Windows sidebars + working on first install
  • I'm down for it. Could also be a way for users to preview the layout customization before these become their own setting options
  • Agree, doable as a standalone feature
  • Same as above
  • I forgot flex-direction: row 🫠. Fixed

BTW I did a mess with the last commits never again editing on GitHub editor. Squash it all 🫥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants