-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments: Sidebar update #1697
Merged
Merged
Comments: Sidebar update #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exciting!
|
- Copied styles from master branch + some changes - Removed "comment" from styleScrollbars func
Merged
Should be all set!
BTW I did a mess with the last commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing idea from #1664.
Preview
Features:
related
videosplayer
width is correctly set through JS (temporary)What's missing yet?
Appearance -> Comments
solely as "Sidebar". Instead, it should be placed inAppearance -> Sidebar
under the name of "Swap Sidebar with Comments"What's not working with
Comments -> Sidebar
activated?Player -> Player Size
other than "normal"Sidebar -> To The Side!
which should get removed in favor of a grid optionAppearance
that affect Sidebar and Comments