Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fullscreen Mode not displaying correctly in Full-Height player size if navigating from theater mode #1722

Closed
Fulgar opened this issue Aug 1, 2023 · 1 comment · Fixed by #1723
Closed

Fullscreen Mode not displaying correctly in Full-Height player size if navigating from theater mode #1722

Fulgar opened this issue Aug 1, 2023 · 1 comment · Fixed by #1723
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@Fulgar
Copy link

Fulgar commented Aug 1, 2023

Bug Report:

⚬ BUG:
I can see the correct/intended player size for theater mode in Full-Height, but the fullscreen mode is displayed incorrectly IF I am in theater mode before going into fullscreen mode. (It stays the same height as theater mode with full-height)

⚬ HOW:

  1. Enable "Full-Height" on Player Size in extension
  2. Ensure that video is in theater mode (NOT in "Default View")
  3. Click fullscreen

If you click fullscreen while in default view it will display correctly, though. (takes up entire screen as expected)

⚬ EXPECTED (/preferred) behavior:
I should be able to go from "Theater" to "Fullscreen" and have the entire screen for the player with "Full-Height" as selected Player Size.
⚬ Screenshots:
image

Setup:

⚬ ImprovedTube Version:
4.27
⚬ Browser:
Chrome Version 115.0.5790.110 (Official Build) (64-bit)
⚬ OS:
Windows 10
@Fulgar Fulgar added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Aug 1, 2023
Fulgar pushed a commit to Fulgar/youtube that referenced this issue Aug 1, 2023
Added an exception for full-height theater mode size so it doesn't br…
8a69458 
…eak fullscreen. fixes code-charity#1722
@Fulgar Fulgar mentioned this issue Aug 1, 2023
Merged
@starobots
Copy link

It‘s the problem from 4.20, the 'old alternative mode - fit to window' is not working at theater mode from that patch.

ImprovedTube pushed a commit that referenced this issue Jan 12, 2024
Added an exception for full-height theater mode size so it doesn't br…
35c6f86 
…eak fullscreen. fixes #1722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Milestone
No milestone
2 participants
@Fulgar @starobots