Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pausable Tokens like USDC can cause liquidation to Fail #639

Open
c4-bot-1 opened this issue Jun 14, 2024 · 0 comments
Open

Pausable Tokens like USDC can cause liquidation to Fail #639

c4-bot-1 opened this issue Jun 14, 2024 · 0 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working 🤖_27_group AI based duplicate group recommendation sufficient quality report This report is of sufficient quality

Comments

@c4-bot-1
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2024-05-predy/blob/main/src/libraries/logic/LiquidationLogic.sol#L99

Vulnerability details

Vulnerability Details

During liquidation, the remaining margin is transferred back to the trader.

Tokens like USDC can be paused, this means that during the pause state liquidation cannot occur, because the transfer will be blocked.

Impact

Impact, loss of funds to the protocol as Liquidatable positions can't be liquidated.

Tools Used

Manual

Recommended Mitigation Steps

Move all transfer logic out of the liquidation.

Assessed type

Token-Transfer
@c4-bot-1 c4-bot-1 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Jun 14, 2024
c4-bot-9 added a commit that referenced this issue Jun 14, 2024
@c4-bot-9
Joshuajee issue #639
89c4502
@c4-bot-12 c4-bot-12 added the 🤖_27_group AI based duplicate group recommendation label Jun 14, 2024
howlbot-integration bot added a commit that referenced this issue Jun 17, 2024
@howlbot-integration
Joshuajee update issue #639
429c03c
@howlbot-integration howlbot-integration bot added the sufficient quality report This report is of sufficient quality label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working 🤖_27_group AI based duplicate group recommendation sufficient quality report This report is of sufficient quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@c4-bot-1 @c4-bot-12