FeegrantKeeper is not checked if defined

[c4-bot-6]

Lines of code

https://github.com/code-423n4/2024-05-canto/blob/d1d51b2293d4689f467b8b1c82bba84f8f7ea008/canto-main/app/ante/handler_options.go#L39-L57

Vulnerability details

Impact

The Validate function will not revert when FeegrantKeeper is nil

Proof of Concept

Here's the Validate function:

// Validate checks if the keepers are defined func (options HandlerOptions) Validate() error { if options.AccountKeeper == nil { return errorsmod.Wrap(sdkerrors.ErrLogic, "account keeper is required for AnteHandler") } if options.BankKeeper == nil { return errorsmod.Wrap(sdkerrors.ErrLogic, "bank keeper is required for AnteHandler") } if options.SignModeHandler == nil { return errorsmod.Wrap(sdkerrors.ErrLogic, "sign mode handler is required for ante builder") } if options.FeeMarketKeeper == nil { return errorsmod.Wrap(sdkerrors.ErrLogic, "fee market keeper is required for AnteHandler") } if options.EvmKeeper == nil { return errorsmod.Wrap(sdkerrors.ErrLogic, "evm keeper is required for AnteHandler") } return nil }

https://github.com/code-423n4/2024-05-canto/blob/d1d51b2293d4689f467b8b1c82bba84f8f7ea008/canto-main/app/ante/handler_options.go#L39-L57

The function does not check if FeegrantKeeper is not nil. Therefore the function will not return an error when FeegrantKeeper is nil.

Tools Used

Manual review

Recommended Mitigation Steps

It's recommended to add a check for the FeeGrantKeeper in the Validate function, similar to the checks for other keepers.

if options.FeegrantKeeper == nil {
return errorsmod.Wrap(sdkerrors.ErrLogic, "fee grant keeper is required for AnteHandler")
}

Assessed type

Context

[ololade97]

I believe this issue is wrongly marked by the bot for insufficient report.

The issue is FeeGrantKeeper is not checked if it is nil like the others in the Validate function. So it will not return an error when nil.

[3docSec]

Insufficient quality is OK here, there is no explanation for how options.FeegrantKeeper can be nil. It is recommended that you put more effort in your findings; remember that the burden of proof is on you, the warden