Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #72

Open
c4-submissions opened this issue Nov 11, 2023 · 4 comments
Open

QA Report #72

c4-submissions opened this issue Nov 11, 2023 · 4 comments
Labels
bug Something isn't working grade-b Q-123 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality

Comments

@c4-submissions
Copy link
Contributor

See the markdown file with the details of this report here.
@c4-submissions c4-submissions added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Nov 11, 2023
c4-submissions added a commit that referenced this issue Nov 11, 2023
@c4-submissions
T1MOH issue #72
df299d4
c4-submissions added a commit that referenced this issue Nov 11, 2023
@c4-submissions
T1MOH data for issue #72
9b4d363
@raymondfam
Copy link

Possible upgrade:

  1. --> LST with different decimals for Chainlink Price Feeds will mint less Amount of RSETH to users. #479

@c4-pre-sort c4-pre-sort added the sufficient quality report This report is of sufficient quality label Nov 18, 2023
@c4-pre-sort
Copy link

raymondfam marked the issue as sufficient quality report

@c4-judge
Copy link
Contributor

c4-judge commented Dec 1, 2023

fatherGoose1 marked the issue as grade-b

@fatherGoose1
Copy link

Not upgrading as it's not a dupe of #479. 479 discusses the different decimals in Chainlink price feeds. LSTs are assumed to mirror ETH's 18 decimals.

@C4-Staff C4-Staff added the Q-123 label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working grade-b Q-123 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fatherGoose1 @raymondfam @c4-judge @c4-pre-sort @C4-Staff @c4-submissions