fulfillRandomWords should never revert

[code423n4]

Lines of code

https://github.com/code-423n4/2023-03-wenwin/blob/91b89482aaedf8b8feb73c771d11c257eed997e8/src/VRFv2RNSource.sol#L33-L35

Vulnerability details

As per chainlink's security considerations, fulfillRandomWords must not revert. However, the callback contains a revert in the case that randomWords.length != 1.

// fulfillRandomWords() - VRFv2RNSource.sol:L33-35
if (randomWords.length != 1) {
	revert WrongRandomNumberCountReceived(requestId, randomWords.length);
}

This pattern is unecessary since we're using randomWords[0] regardless, and >1 randomWords.length would not cause any issues.

// fulfillRandomWords() - VRFv2RNSource.sol:L37
fulfill(requestId, randomWords[0]);

[c4-judge]

thereksfour marked the issue as duplicate of #445

[c4-judge]

thereksfour changed the severity to QA (Quality Assurance)