Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Optimizations #478

Open
code423n4 opened this issue Sep 1, 2022 · 0 comments
Open

Gas Optimizations #478

code423n4 opened this issue Sep 1, 2022 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

code423n4 commented Sep 1, 2022

Pre-incrementing is cheaper than post-incrementing
Consider replacing e.g. i++ with ++i.

Instances:
KernelUtils.sol: 49 64

 

Function not called by the contract can be external instead of public

Instances:
Kernel.sol: 95 100 439 451
TRSRY.sol: 47 79
MINTR.sol: 20 25 33 37
RANGE.sol: 110 115 219
PRICE.sol: 108 113
VOTES.sol: 22 27 45 55
INSTR.sol: 23 28 37
Governance.sol: 145 151

 

Pre-compute .length before repeated usage, especially in loops

Instances:
Governance.sol#L278

 

observations.length is already computed in numObservations
uint256 numObs = observations.length;can be changed into uint256 numObs = numObservations; as suggested by its preceding comment, because its length is already calculated during construction.
PRICE.sol#L212

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Sep 1, 2022
code423n4 added a commit that referenced this issue Sep 1, 2022
code423n4 added a commit that referenced this issue Sep 1, 2022
@0xLienid 0xLienid added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Development

No branches or pull requests

2 participants