QA Report #53
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Lack of zero-address check
Details
It is important for critical functionalities to add zero-address check. Lack of zero-address check in the
_setPendingAdmin
function ofGovernorBravoDelegate.sol
may lead to loss of control to admin functionalities in the event of accidentally setting the parameter to address(0).Mitigation
I suggest adding this require statement:
require(newPendingAdmin != address(0));
Line of code
https://github.com/Plex-Engineer/lending-market-v2/blob/ea5840de72eab58bec837bb51986ac73712fcfde/contracts/Governance/GovernorBravoDelegate.sol#L138-L150
The text was updated successfully, but these errors were encountered: